From: Jan Olszak <j.olszak@samsung.com>
Date: Mon, 10 Dec 2012 09:50:33 +0000 (+0100)
Subject: [Prevent] Handle remove() return value
X-Git-Tag: submit/trunk/20121213.022635~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=012b68bf7234b7fde7fd75300db5d96848600866;p=platform%2Fframework%2Fweb%2Fwrt-commons.git

[Prevent] Handle remove() return value

[Issue#] Return value not handled.
[Bug] no. 22805
[Cause] N/A
[Solution] Log error on remove fail.
[Verification] Build commons.

Change-Id: I1c20be3caaef13d43599b3ce5522d6cbde30c330
---

diff --git a/modules/test/src/test_results_collector.cpp b/modules/test/src/test_results_collector.cpp
index 7daf3c6..d481aa5 100644
--- a/modules/test/src/test_results_collector.cpp
+++ b/modules/test/src/test_results_collector.cpp
@@ -27,6 +27,7 @@
 #include <dpl/scoped_fclose.h>
 
 #include <string>
+#include <string.h>
 #include <cstdio>
 #include <fstream>
 #include <sstream>
@@ -438,8 +439,10 @@ class XmlCollector
             m_outputBuffer.erase(posBegin - 3, posEnd - posBegin + sizeof("</testcase>") + 2);
         }
 
+        if(remove(m_filename.c_str())!=0){
+            LogError("Can't remove file. Error: " << strerror(errno));
+        }
 
-        remove(m_filename.c_str());
         m_fp.Reset(fopen (m_filename.c_str(), "w"));
         Assert(!!m_fp && "File handle must not be null");
         fseek(m_fp.Get(), 0L, SEEK_SET);