From: bmeurer@chromium.org Date: Tue, 5 Nov 2013 08:58:34 +0000 (+0000) Subject: ARM: Use loop to initialize locals when optimizing for size. X-Git-Tag: upstream/4.7.83~11911 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=011ca83783126e24fbd0eb9ef9d25666cf256cda;p=platform%2Fupstream%2Fv8.git ARM: Use loop to initialize locals when optimizing for size. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/52163002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17465 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc index c57c785..02d1933 100644 --- a/src/arm/full-codegen-arm.cc +++ b/src/arm/full-codegen-arm.cc @@ -168,9 +168,20 @@ void FullCodeGenerator::Generate() { // Generators allocate locals, if any, in context slots. ASSERT(!info->function()->is_generator() || locals_count == 0); if (locals_count > 0) { - __ LoadRoot(ip, Heap::kUndefinedValueRootIndex); - for (int i = 0; i < locals_count; i++) { - __ push(ip); + // Emit a loop to initialize stack cells for locals when optimizing for + // size. Otherwise, unroll the loop for maximum performance. + __ LoadRoot(r9, Heap::kUndefinedValueRootIndex); + if (FLAG_optimize_for_size && locals_count > 4) { + Label loop; + __ mov(r2, Operand(locals_count)); + __ bind(&loop); + __ sub(r2, r2, Operand(1), SetCC); + __ push(r9); + __ b(&loop, ne); + } else { + for (int i = 0; i < locals_count; i++) { + __ push(r9); + } } } }