From: Alban Bedel Date: Mon, 7 Jan 2019 19:44:53 +0000 (+0100) Subject: phy: ath79-usb: Fix the power on error path X-Git-Tag: v5.15~6882^2~43^2~33 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=009808154c69c48d5b41fc8cf5ad5ab5704efd8f;p=platform%2Fkernel%2Flinux-starfive.git phy: ath79-usb: Fix the power on error path In the power on function the error path doesn't return the suspend override to its proper state. It should should deassert this reset line to enable the suspend override. Signed-off-by: Alban Bedel Signed-off-by: Kishon Vijay Abraham I --- diff --git a/drivers/phy/qualcomm/phy-ath79-usb.c b/drivers/phy/qualcomm/phy-ath79-usb.c index 6fd6e07..f7d64f3 100644 --- a/drivers/phy/qualcomm/phy-ath79-usb.c +++ b/drivers/phy/qualcomm/phy-ath79-usb.c @@ -31,7 +31,7 @@ static int ath79_usb_phy_power_on(struct phy *phy) err = reset_control_deassert(priv->reset); if (err && priv->no_suspend_override) - reset_control_assert(priv->no_suspend_override); + reset_control_deassert(priv->no_suspend_override); return err; }