From: Martin Storsjö Date: Thu, 30 Mar 2023 09:35:08 +0000 (+0000) Subject: [compiler-rt] Create the umbrella check-compiler-rt test target in non-standalone... X-Git-Tag: upstream/17.0.6~12462 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=002897b5f1b253a6c78b6a1790952b4f399623c2;p=platform%2Fupstream%2Fllvm.git [compiler-rt] Create the umbrella check-compiler-rt test target in non-standalone builds too I don't see why we can't have this target when built as a project alongside llvm; especially in such build configs, it's useful to have one single target for running all tests (in standalone builds, check-all does the same too), Keep the creation of the check-all target only for standalone builds. Differential Revision: https://reviews.llvm.org/D147646 --- diff --git a/compiler-rt/test/CMakeLists.txt b/compiler-rt/test/CMakeLists.txt index b4d2999..69e17af 100644 --- a/compiler-rt/test/CMakeLists.txt +++ b/compiler-rt/test/CMakeLists.txt @@ -43,9 +43,7 @@ if(NOT ANDROID) endif() endif() -if(COMPILER_RT_STANDALONE_BUILD) - umbrella_lit_testsuite_begin(check-compiler-rt) -endif() +umbrella_lit_testsuite_begin(check-compiler-rt) function(compiler_rt_test_runtime runtime) string(TOUPPER ${runtime} runtime_uppercase) @@ -110,12 +108,12 @@ if(COMPILER_RT_CAN_EXECUTE_TESTS) add_subdirectory(shadowcallstack) endif() -if(COMPILER_RT_STANDALONE_BUILD) - # Now that we've traversed all the directories and know all the lit testsuites, - # introduce a rule to run to run all of them. - add_custom_target(compiler-rt-test-depends DEPENDS ${LLVM_COMPILER_RT_LIT_DEPENDS}) - umbrella_lit_testsuite_end(check-compiler-rt) +# Now that we've traversed all the directories and know all the lit testsuites, +# introduce a rule to run to run all of them. +add_custom_target(compiler-rt-test-depends DEPENDS ${LLVM_COMPILER_RT_LIT_DEPENDS}) +umbrella_lit_testsuite_end(check-compiler-rt) +if(COMPILER_RT_STANDALONE_BUILD) if(NOT TARGET check-all) add_custom_target(check-all) endif()