From: Tom Tromey <tom@tromey.com>
Date: Thu, 5 Apr 2018 21:39:57 +0000 (-0600)
Subject: Add a fall-through comment to stabsread.c
X-Git-Tag: binutils-2_31~534
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0019cd49ca954c03737cef3a8ee60c233d081d35;p=external%2Fbinutils.git

Add a fall-through comment to stabsread.c

This adds a fall-through comment to stabsread.c.  I skimmed the stabs
manual a bit and it seems that 'p' and 'P' are similar enough that
this makes sense.  Also, stabs is mostly deprecated, and the code has
been this way for a long time, so it seemed safest to keep the status
quo.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* stabsread.c (define_symbol) <case 'p'>: Add fall-through
	comment.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4bdd444..8e767c0 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2018-05-04  Tom Tromey  <tom@tromey.com>
 
+	* stabsread.c (define_symbol) <case 'p'>: Add fall-through
+	comment.
+
+2018-05-04  Tom Tromey  <tom@tromey.com>
+
 	* riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
 	* utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
 	* eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
diff --git a/gdb/stabsread.c b/gdb/stabsread.c
index 8d39290..a56702a 100644
--- a/gdb/stabsread.c
+++ b/gdb/stabsread.c
@@ -1100,6 +1100,7 @@ define_symbol (CORE_ADDR valu, const char *string, int desc, int type,
 	    }
 	  break;
 	}
+      /* Fall through.  */
 
     case 'P':
       /* acc seems to use P to declare the prototypes of functions that