From: Sangyoon Jang Date: Fri, 28 Apr 2017 06:00:29 +0000 (+0900) Subject: Fix wrong condition checking X-Git-Tag: accepted/tizen/unified/20170510.183503~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;ds=sidebyside;h=df95188880bef4c247f84aa0ec2b8c7166de0469;p=platform%2Fcore%2Fappfw%2Fpkgmgr-info.git Fix wrong condition checking Change-Id: I7032b82c9ca82efca7362ca77cbf153db55075ed Signed-off-by: Sangyoon Jang --- diff --git a/src/pkgmgrinfo_archiveinfo.c b/src/pkgmgrinfo_archiveinfo.c index 0a8c2b8..fef594f 100644 --- a/src/pkgmgrinfo_archiveinfo.c +++ b/src/pkgmgrinfo_archiveinfo.c @@ -91,7 +91,7 @@ API int pkgmgrinfo_archiveinfo_get_pkgid(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL || strlen(info->pkgid)) { + if (info == NULL || strlen(info->pkgid) == 0) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } @@ -107,7 +107,7 @@ API int pkgmgrinfo_archiveinfo_get_type(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL || strlen(info->pkg_type)) { + if (info == NULL || strlen(info->pkg_type) == 0) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } @@ -123,7 +123,7 @@ API int pkgmgrinfo_archiveinfo_get_version(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL || strlen(info->version)) { + if (info == NULL || strlen(info->version) == 0) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; } @@ -139,7 +139,7 @@ API int pkgmgrinfo_archiveinfo_get_api_version(pkgmgrinfo_archiveinfo_h handle, package_manager_pkg_detail_info_t *info = (package_manager_pkg_detail_info_t *)handle; - if (info == NULL || strlen(info->api_version)) { + if (info == NULL || strlen(info->api_version) == 0) { _LOGE("invalid parameter"); return PMINFO_R_EINVAL; }