From: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Date: Fri, 28 Oct 2011 09:28:59 +0000 (+0300)
Subject: gdhcp: Possible file descriptor leak
X-Git-Tag: 2.0_alpha~978
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;ds=sidebyside;h=adf8327243aba249cd3b50690c2ca369fafaee8d;p=framework%2Fconnectivity%2Fconnman.git

gdhcp: Possible file descriptor leak
---

diff --git a/gdhcp/common.c b/gdhcp/common.c
index 43f6735..0a2b51b 100644
--- a/gdhcp/common.c
+++ b/gdhcp/common.c
@@ -343,11 +343,11 @@ int dhcp_send_raw_packet(struct dhcp_packet *dhcp_pkt,
 	 */
 	n = sendto(fd, &packet, IP_UPD_DHCP_SIZE, 0,
 			(struct sockaddr *) &dest, sizeof(dest));
+	close(fd);
+
 	if (n < 0)
 		return -errno;
 
-	close(fd);
-
 	return n;
 }