From: U. Artie Eoff Date: Fri, 10 Jan 2020 17:26:44 +0000 (-0800) Subject: plugins: overlay: use proper NULL check on double pointer X-Git-Tag: 1.19.3~503^2~318 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;ds=sidebyside;h=ad31d5bb8184f67de6755d4a404ff0aa306f67b2;p=platform%2Fupstream%2Fgstreamer.git plugins: overlay: use proper NULL check on double pointer Check the address of the variable is not NULL, not the address of the pointer. --- diff --git a/gst/vaapi/gstvaapioverlay.c b/gst/vaapi/gstvaapioverlay.c index f3baf75..b478d43 100644 --- a/gst/vaapi/gstvaapioverlay.c +++ b/gst/vaapi/gstvaapioverlay.c @@ -446,7 +446,7 @@ gst_vaapi_overlay_create_output_buffer (GstVideoAggregator * vagg, *outbuf = NULL; if ((gst_buffer_pool_acquire_buffer (pool, outbuf, NULL) != GST_FLOW_OK) - || !outbuf) { + || !*outbuf) { GST_ERROR_OBJECT (overlay, "failed to create output video buffer"); return GST_FLOW_ERROR; }