From: David Svensson Fors <davidsf@axis.com>
Date: Thu, 22 Oct 2015 07:15:21 +0000 (+0200)
Subject: rtsp-stream: Always unref return value of gst_object_get_parent()
X-Git-Tag: 1.19.3~495^2~592
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;ds=sidebyside;h=81ae320383894892b4b4b53482a04c998441430d;p=platform%2Fupstream%2Fgstreamer.git

rtsp-stream: Always unref return value of gst_object_get_parent()

Fixes a leak of a GstBin in the udp-mcast case.

https://bugzilla.gnome.org/show_bug.cgi?id=756968
---

diff --git a/gst/rtsp-server/rtsp-stream.c b/gst/rtsp-server/rtsp-stream.c
index 4e5f644..60442ad 100644
--- a/gst/rtsp-server/rtsp-stream.c
+++ b/gst/rtsp-server/rtsp-stream.c
@@ -2881,7 +2881,6 @@ update_transport (GstRTSPStream * stream, GstRTSPStreamTransport * trans,
           gst_object_unref (pad);
           gst_object_unref (selpad);
         }
-        gst_object_unref (bin);
 
         priv->transport_sources =
             g_list_prepend (priv->transport_sources, source);
@@ -2917,6 +2916,8 @@ update_transport (GstRTSPStream * stream, GstRTSPStreamTransport * trans,
         }
       }
 
+      gst_object_unref (bin);
+
       /* fall through for the generic case */
     }
     case GST_RTSP_LOWER_TRANS_UDP: