From: Seoyeon Kim <seoyeon2.kim@samsung.com>
Date: Wed, 28 Mar 2018 02:17:00 +0000 (+0900)
Subject: Fix Coverity issues
X-Git-Tag: accepted/tizen/4.0/unified/20190104.230754~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;ds=sidebyside;h=4c6443759f21f09346951b4561675292351557d0;p=platform%2Fcore%2Fuifw%2Fdali-adaptor.git

Fix Coverity issues

- sensor_is_supported() has a return value, int type.
  In tilt-sensor-impl-tizen.cpp, there is an omitted return check code
  at 146 line. So, added to check the return value of sensor_is_supported.

- Fixed to memory leak in clipboard-impl-ecore-wl.
  Variable 'reply' is allocated from 'eldbus_proxy_send_and_block()'
  So, added to eldbus_message_unref(reply) for memory free.

Change-Id: I9a389508430d3b209e886f3dc83e7898350b92e0
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
---

diff --git a/adaptors/ecore/wayland/clipboard-impl-ecore-wl.cpp b/adaptors/ecore/wayland/clipboard-impl-ecore-wl.cpp
index 0839ca2..68a10e5 100644
--- a/adaptors/ecore/wayland/clipboard-impl-ecore-wl.cpp
+++ b/adaptors/ecore/wayland/clipboard-impl-ecore-wl.cpp
@@ -162,6 +162,10 @@ struct Clipboard::Impl
       DALI_LOG_ERROR("Unable to call method org.freedesktop.DBus.Properties.Get: %s %s",
       errname, errmsg);
       eldbus_message_unref(req);
+      if( reply )
+      {
+        eldbus_message_unref(reply);
+      }
       return -1;
     }
 
@@ -169,10 +173,12 @@ struct Clipboard::Impl
     {
       DALI_LOG_ERROR("Cannot get arguments from eldbus");
       eldbus_message_unref(req);
+      eldbus_message_unref(reply);
       return -1;
     }
 
     eldbus_message_unref(req);
+    eldbus_message_unref(reply);
     DALI_LOG_ERROR("cbhm item count(%d)", count);
     return count;
   }
diff --git a/adaptors/tizen/tilt-sensor-impl-tizen.cpp b/adaptors/tizen/tilt-sensor-impl-tizen.cpp
index 58cf46d..d4d9aef 100644
--- a/adaptors/tizen/tilt-sensor-impl-tizen.cpp
+++ b/adaptors/tizen/tilt-sensor-impl-tizen.cpp
@@ -171,7 +171,13 @@ bool TiltSensor::Connect()
   {
     DALI_LOG_ERROR("sensor does not support SENSOR_ORIENTATION\n");
 
-    sensor_is_supported(SENSOR_ACCELEROMETER, &isSupported);
+    ret = sensor_is_supported(SENSOR_ACCELEROMETER, &isSupported);
+
+    if(ret < 0)
+    {
+      DALI_LOG_ERROR("sensor_is_supported() failed : %s\n", get_sensor_error_string(ret).c_str());
+      return false;
+    }
 
     if(isSupported == false)
     {