From: Gilbok Lee <gilbok.lee@samsung.com>
Date: Mon, 20 Mar 2023 06:04:59 +0000 (+0900)
Subject: rtp/rtpmanager: Fix coverity issues
X-Git-Tag: accepted/tizen/unified/20230321.123150^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;ds=sidebyside;h=1ed84a846f79f7bb362d7dcb54d698c27c7feb45;hp=a29d75132f8a0f64ef3e03d38d3040a093fd0dd2;p=platform%2Fupstream%2Fgstreamer.git

rtp/rtpmanager: Fix coverity issues

[Version] 1.22.0-23
[Issue Type] Bug fix

Change-Id: Icf0d13883b071cc87c6279ae578adcc4e2bb2144
---

diff --git a/packaging/gstreamer.spec b/packaging/gstreamer.spec
index 516512d..20fb796 100644
--- a/packaging/gstreamer.spec
+++ b/packaging/gstreamer.spec
@@ -62,7 +62,7 @@
 
 Name:           %{_name}
 Version:        1.22.0
-Release:        22
+Release:        23
 Summary:        Streaming-Media Framework Runtime
 License:        LGPL-2.0+
 Group:          Multimedia/Framework
diff --git a/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtpbasedepayload.c b/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtpbasedepayload.c
index 0fd2d82..046c7b2 100644
--- a/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtpbasedepayload.c
+++ b/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtpbasedepayload.c
@@ -1261,6 +1261,9 @@ read_rtp_header_extensions (GstRTPBaseDepayload * depayload,
                 read_len, output)) {
           GST_WARNING_OBJECT (depayload, "RTP header extension (%s) could "
               "not read payloaded data", GST_OBJECT_NAME (ext));
+#ifdef TIZEN_FEATURE_BUG_FIX
+          GST_OBJECT_UNLOCK (depayload);
+#endif
           gst_object_unref (ext);
           goto out;
         }
diff --git a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpjitterbuffer.c b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpjitterbuffer.c
index 063e39b..2c2c1f0 100644
--- a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpjitterbuffer.c
+++ b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpjitterbuffer.c
@@ -4729,7 +4729,11 @@ gst_rtp_jitter_buffer_chain_rtcp (GstPad * pad, GstObject * parent,
   GstRtpJitterBuffer *jitterbuffer;
   GstRtpJitterBufferPrivate *priv;
   GstFlowReturn ret = GST_FLOW_OK;
+#ifdef TIZEN_FEATURE_BUG_FIX
+  guint32 ssrc = 0;
+#else
   guint32 ssrc;
+#endif
   GstRTCPPacket packet;
   guint64 ext_rtptime, ntptime;
   GstClockTime ntpnstime = GST_CLOCK_TIME_NONE;
diff --git a/subprojects/gst-plugins-good/gst/rtpmanager/rtpsession.c b/subprojects/gst-plugins-good/gst/rtpmanager/rtpsession.c
index 294bcf0..b72bc5e 100644
--- a/subprojects/gst-plugins-good/gst/rtpmanager/rtpsession.c
+++ b/subprojects/gst-plugins-good/gst/rtpmanager/rtpsession.c
@@ -2945,7 +2945,13 @@ rtp_session_process_sr_req (RTPSession * sess, guint32 sender_ssrc,
   /* FIXME: 5s max_delay hard-coded here as we have to give some
    * high enough value */
   sess->sr_req_pending = TRUE;
+#ifdef TIZEN_FEATURE_BUG_FIX
+  RTP_SESSION_UNLOCK (sess);
+#endif
   rtp_session_send_rtcp (sess, 5 * GST_SECOND);
+#ifdef TIZEN_FEATURE_BUG_FIX
+  RTP_SESSION_LOCK (sess);
+#endif
 }
 
 static void