From: Mike Gorse <mgorse@suse.com>
Date: Fri, 3 May 2013 14:48:50 +0000 (-0500)
Subject: Add a NULL check into register_reply
X-Git-Tag: AT_SPI2_ATK_2_12_0~33
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;ds=sidebyside;h=031946b5b7ec90279ae60bbf974f23979979ea78;p=platform%2Fcore%2Fuifw%2Fat-spi2-atk.git

Add a NULL check into register_reply

Register_reply could access invalid memory if it is called after
atk_bridge_adaptor_cleanup() has been called.

This code should probably be refactored to make the instance act as a
GObject, but committing this for now to fix the crash.

https://bugzilla.gnome.org/show_bug.cgi?id=699554
---

diff --git a/atk-adaptor/bridge.c b/atk-adaptor/bridge.c
index 1a36f14..e59c834 100644
--- a/atk-adaptor/bridge.c
+++ b/atk-adaptor/bridge.c
@@ -235,6 +235,14 @@ register_reply (DBusPendingCall *pending, void *user_data)
 
   reply = dbus_pending_call_steal_reply (pending);
   dbus_pending_call_unref (pending);
+
+  if (!spi_global_app_data)
+    {
+      if (reply)
+         dbus_message_unref (reply);
+      return;
+    }
+
   if (reply)
     {
       gchar *app_name, *obj_path;