prevent invalid releasing memory 32/256732/1 accepted/tizen/6.5/unified/20211028.094316 accepted/tizen/unified/20210413.021236 submit/tizen/20210412.064024 submit/tizen_6.5/20211028.161701 tizen_6.5.m2_release
authorYoungjae Shin <yj99.shin@samsung.com>
Mon, 12 Apr 2021 06:33:18 +0000 (15:33 +0900)
committerYoungjae Shin <yj99.shin@samsung.com>
Mon, 12 Apr 2021 06:33:18 +0000 (15:33 +0900)
Change-Id: Iea4a87692ff1f9b8a8d4cdd40e65ae1b8d42378e

src/trigger/context_trigger.cpp

index 928246f..91962f9 100644 (file)
@@ -644,11 +644,12 @@ static bool __is_valid_pkg_id(const char* pkgId)
 {
        IF_FAIL_RETURN(pkgId, false);
 
-       pkgmgrinfo_pkginfo_h pkgInfo;
+       pkgmgrinfo_pkginfo_h pkgInfo = NULL;
        int err = pkgmgrinfo_pkginfo_get_usr_pkginfo(pkgId, getuid(), &pkgInfo);
-       pkgmgrinfo_pkginfo_destroy_pkginfo(pkgInfo);
+       IF_FAIL_RETURN_TAG(err == PMINFO_R_OK, false, _E, "pkgmgrinfo_pkginfo_get_usr_pkginfo() Fail");
 
-       return (PMINFO_R_OK == err);
+       pkgmgrinfo_pkginfo_destroy_pkginfo(pkgInfo);
+       return true;
 }
 
 EXPORT_API int context_trigger_rule_custom_event_create(const char* event_item, const char* provider, context_trigger_logical_type_e logical_type, context_trigger_rule_entry_h* entry)