Remove Smack rules having wrong subject 65/27165/1 accepted/tizen/common/20140908.193650 accepted/tizen/ivi/20140912.193607 submit/tizen_common/20140908.122758 submit/tizen_ivi/20140912.000000
authorJosé Bollo <jose.bollo@open.eurogiciel.org>
Fri, 5 Sep 2014 10:15:21 +0000 (12:15 +0200)
committerJosé Bollo <jose.bollo@open.eurogiciel.org>
Fri, 5 Sep 2014 10:15:21 +0000 (12:15 +0200)
Names of the software repositories were used as subject of
the generated smack rules. There is no mention of such
behaviour on the help pages in the wiki of tizen.

Bug-Tizen: PTREL-638

Change-Id: Iefef89492ab5c9839cb01d3b62dae4c3637f00f4
Signed-off-by: José Bollo <jose.bollo@open.eurogiciel.org>
plugins/msmxattr.c

index b7dc919..2665dfc 100644 (file)
@@ -179,9 +179,14 @@ static int msmSetSmackProvide(struct smack_accesses *smack_accesses, provide_x *
                 rpmlog(RPMLOG_DEBUG, "%s ac_domain %s provided in %s for %s\n", (ac_domain->allowed ? "allowing" : "not allowing"), 
                        ac_domain->name, ac_domain->sw_source->name, sw_source->name);
            }
+/* FIXME(José Bollo): I'm removing this call that has the effect to create rules having the
+sw_source->name as subject. I'm thinking that this behaviour is not expected.
+It is solving the bug https://bugs.tizen.org/jira/browse/PTREL-638.
+
            if (smack_accesses)
                ret = msmSetSmackRules(smack_accesses, provide->ac_domains, sw_source->name);
            else 
+*/
                 ret = 0;
        }
     }