Fix memory leak issue using tcore_storage_get_string()

Change-Id: I22ccaf0e11e06920da84491b8012165009d1ec4b

diff --git a/packaging/tel-plugin-dbus_tapi.spec b/packaging/tel-plugin-dbus_tapi.spec
index a34d09e..d7baf4a 100644 (file)
--- a/packaging/tel-plugin-dbus_tapi.spec
+++ b/packaging/tel-plugin-dbus_tapi.spec
@@ -1,6 +1,6 @@
 %define major 0
 %define minor 3
-%define patchlevel 83
+%define patchlevel 84
 
 Name:           tel-plugin-dbus_tapi
 Version:        %{major}.%{minor}.%{patchlevel}

diff --git a/src/dtapi_sat_manager.c b/src/dtapi_sat_manager.c
index 49b31dc..e4ee802 100644 (file)
--- a/src/dtapi_sat_manager.c
+++ b/src/dtapi_sat_manager.c
@@ -417,7 +417,7 @@ static gboolean sat_manager_check_availiable_event_list(struct tel_sat_setup_eve
        gboolean rv = FALSE;
        int local_index = 0;
        unsigned char count = event_list_tlv->event_list.event_list_cnt;
-       if(count <= 0)
+       if (count <= 0)
                return rv;
 
        /*
@@ -2383,7 +2383,7 @@ GVariant* sat_manager_refresh_noti(struct custom_data *ctx, const char *cp_name,
        GVariantBuilder builder;
        GVariant *file_list = NULL;
        int local_index = 0;
-       gushort text_len =0;
+       gushort text_len = 0;
        gchar text[SAT_TEXT_STRING_LEN_MAX];
 #if defined(TIZEN_SUPPORT_SAT_ICON)
        GVariant *icon_id = NULL;
@@ -2411,12 +2411,12 @@ GVariant* sat_manager_refresh_noti(struct custom_data *ctx, const char *cp_name,
        file_list = g_variant_builder_end(&builder);
 
        //enqueue data and generate cmd_id
-       if( refresh_tlv->alpha_id.is_exist && refresh_tlv->alpha_id.alpha_data_len){
-               tcore_util_convert_string_to_utf8((unsigned char*)&text,(unsigned short *)&text_len,
+       if (refresh_tlv->alpha_id.is_exist && refresh_tlv->alpha_id.alpha_data_len) {
+               tcore_util_convert_string_to_utf8((unsigned char*)&text, (unsigned short *)&text_len,
                                refresh_tlv->alpha_id.dcs.a_format,
                                (unsigned char*)&refresh_tlv->alpha_id.alpha_data,
                                (unsigned short)refresh_tlv->alpha_id.alpha_data_len);
-               dbg("refresh ui display text (%s)",text);
+               dbg("refresh ui display text (%s)", text);
        }
 
        //enqueue data and generate cmd_id
@@ -2432,8 +2432,8 @@ GVariant* sat_manager_refresh_noti(struct custom_data *ctx, const char *cp_name,
 
 #if defined(TIZEN_SUPPORT_SAT_ICON)
        /* Icon data extraction */
-       g_variant_builder_init(&v_builder_icon, G_VARIANT_TYPE ("a(biiiiiis)"));
-       if(refresh_tlv->icon_id.is_exist) {
+       g_variant_builder_init(&v_builder_icon, G_VARIANT_TYPE("a(biiiiiis)"));
+       if (refresh_tlv->icon_id.is_exist) {
                g_variant_builder_add(&v_builder_icon, "(biiiiiis)", refresh_tlv->icon_id.is_exist, refresh_tlv->icon_id.icon_qualifer, (gint32) refresh_tlv->icon_id.icon_identifier, (gint32) refresh_tlv->icon_id.icon_info.width,
                        (gint32) refresh_tlv->icon_id.icon_info.height, refresh_tlv->icon_id.icon_info.ics, refresh_tlv->icon_id.icon_info.icon_data_len, refresh_tlv->icon_id.icon_info.icon_file);
        }
@@ -2852,8 +2852,10 @@ GVariant* sat_manager_provide_local_info_noti(struct custom_data *ctx, const cha
                s = ctx->server;
                strg = tcore_server_find_storage(s, "vconf");
                lang_str = tcore_storage_get_string(strg, STORAGE_KEY_LANGUAGE_SET);
-               if (lang_str)
+               if (lang_str) {
                        lang_type = _convert_string_to_sim_lang(lang_str);
+                       free(lang_str);
+               }
 
                tr->terminal_rsp_data.provide_local_info.other.language = lang_type;
                } break;