Revise CMakeLists.txt, pc file 83/34583/2 accepted/tizen/mobile/20150313.083939 accepted/tizen/tv/20150302.010502 accepted/tizen/tv/20150313.083822 accepted/tizen/wearable/20150313.083852 submit/tizen/20150304.022845 submit/tizen_common/20150226.010729 submit/tizen_mobile/20150313.022842 submit/tizen_tv/20150227.073215 submit/tizen_tv/20150228.021455 submit/tizen_tv/20150313.022842 submit/tizen_wearable/20150313.022842
authorSangyoon Jang <s89.jang@samsung.com>
Thu, 29 Jan 2015 09:06:14 +0000 (18:06 +0900)
committerSangyoon Jang <s89.jang@samsung.com>
Thu, 29 Jan 2015 10:09:01 +0000 (19:09 +0900)
clean up and remove unnecessary variables
remove empty lines at pc file

Change-Id: I2d9350ca741a0ee773392bab5d55dfac1186d70e
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
CMakeLists.txt
capi-appfw-package-manager.pc.in

index d664946..195e248 100644 (file)
@@ -1,93 +1,42 @@
-
 CMAKE_MINIMUM_REQUIRED(VERSION 2.6)
-SET(fw_name "capi-appfw-package-manager")
 
-PROJECT(${fw_name})
+PROJECT(capi-appfw-package-manager C)
+SET(SOURCES src/package_info.c
+       src/package_manager.c
+       src/package_manager_internal.c)
 
-SET(CMAKE_INSTALL_PREFIX /usr)
-SET(PREFIX ${CMAKE_INSTALL_PREFIX})
+INCLUDE(FindPkgConfig)
+pkg_check_modules(PKGS REQUIRED
+       capi-base-common
+       dlog
+       vconf
+       aul
+       ail
+       pkgmgr
+       pkgmgr-info
+       libtzplatform-config)
+FOREACH(FLAGS ${PKGS_CFLAGS})
+       SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${FLAGS}")
+ENDFOREACH(FLAGS)
 
 SET(INC_DIR include)
 INCLUDE_DIRECTORIES(${INC_DIR})
 
-SET(requires "capi-base-common dlog vconf aul ail pkgmgr pkgmgr-info libtzplatform-config")
-SET(pc_requires "capi-base-common")
-
-INCLUDE(FindPkgConfig)
-pkg_check_modules(${fw_name} REQUIRED ${requires})
-FOREACH(flag ${${fw_name}_CFLAGS})
-    SET(EXTRA_CFLAGS "${EXTRA_CFLAGS} ${flag}")
-ENDFOREACH(flag)
+ADD_LIBRARY(${PROJECT_NAME} SHARED ${SOURCES})
+TARGET_LINK_LIBRARIES(${PROJECT_NAME} ${PKGS_LDFLAGS})
 
-SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -fPIC -Wall -fvisibility=hidden")
+SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fPIC -Wall -fvisibility=hidden")
 SET(CMAKE_C_FLAGS_DEBUG "-O0 -g")
 
-IF("${ARCH}" STREQUAL "arm")
-    ADD_DEFINITIONS("-DTARGET")
-ENDIF("${ARCH}" STREQUAL "arm")
-
-ADD_DEFINITIONS("-DPREFIX=\"${CMAKE_INSTALL_PREFIX}\"")
-ADD_DEFINITIONS("-DSLP_DEBUG")
-
-SET(CMAKE_EXE_LINKER_FLAGS "-Wl,--as-needed -Wl,--rpath=${LIB_INSTALL_DIR}")
-
-aux_source_directory(src SOURCES)
-ADD_LIBRARY(${fw_name} SHARED ${SOURCES})
+SET_TARGET_PROPERTIES(${PROJECT_NAME} PROPERTIES VERSION ${FULLVER})
+SET_TARGET_PROPERTIES(${PROJECT_NAME} PROPERTIES SOVERSION ${MAJORVER})
+SET_TARGET_PROPERTIES(${PROJECT_NAME} PROPERTIES CLEAN_DIRECT_OUTPUT 1)
 
-TARGET_LINK_LIBRARIES(${fw_name} ${${fw_name}_LDFLAGS})
+SET(PC_PREFIX ${CMAKE_INSTALL_PREFIX})
+CONFIGURE_FILE(capi-appfw-package-manager.pc.in ${CMAKE_CURRENT_SOURCE_DIR}/${PROJECT_NAME}.pc @ONLY)
 
-SET_TARGET_PROPERTIES(${fw_name}
-     PROPERTIES
-     VERSION ${FULLVER}
-     SOVERSION ${MAJORVER}
-     CLEAN_DIRECT_OUTPUT 1
-)
-
-INSTALL(TARGETS ${fw_name} DESTINATION ${LIB_INSTALL_DIR})
+INSTALL(TARGETS ${PROJECT_NAME} DESTINATION ${LIB_INSTALL_DIR})
 INSTALL(DIRECTORY ${INC_DIR}/ DESTINATION include/appfw)
+INSTALL(FILES ${CMAKE_CURRENT_SOURCE_DIR}/${PROJECT_NAME}.pc DESTINATION ${LIB_INSTALL_DIR}/pkgconfig)
 
-SET(PC_NAME ${fw_name})
-SET(PC_REQUIRED ${pc_requires})
-SET(PC_LDFLAGS -l${fw_name})
-SET(PC_CFLAGS -I\${includedir}/appfw)
-
-CONFIGURE_FILE(
-    capi-appfw-package-manager.pc.in
-    ${CMAKE_CURRENT_SOURCE_DIR}/${fw_name}.pc
-    @ONLY
-)
-INSTALL(FILES ${CMAKE_CURRENT_SOURCE_DIR}/${fw_name}.pc DESTINATION ${LIB_INSTALL_DIR}/pkgconfig)
-
-
-IF(UNIX)
-
-ADD_CUSTOM_TARGET (distclean @echo cleaning for source distribution)
-ADD_CUSTOM_COMMAND(
-        DEPENDS clean
-        COMMENT "distribution clean"
-        COMMAND find
-        ARGS    .
-        -not -name config.cmake -and \(
-        -name tester.c -or
-        -name Testing -or
-        -name CMakeFiles -or
-        -name cmake.depends -or
-        -name cmake.check_depends -or
-        -name CMakeCache.txt -or
-        -name cmake.check_cache -or
-        -name *.cmake -or
-        -name Makefile -or
-        -name core -or
-        -name core.* -or
-        -name gmon.out -or
-        -name install_manifest.txt -or
-        -name *.pc -or
-        -name *~ \)
-        | grep -v TC | xargs rm -rf
-        TARGET  distclean
-        VERBATIM
-)
-
-ENDIF(UNIX)
-
-add_subdirectory(tool)
+ADD_SUBDIRECTORY(tool)
index 4881866..675cb41 100644 (file)
@@ -1,15 +1,13 @@
-
 # Package Information for pkg-config
 
-prefix=@PREFIX@
-exec_prefix=/usr
+prefix=@PC_PREFIX@
+exec_prefix=@PC_PREFIX@
 libdir=@LIB_INSTALL_DIR@
-includedir=/usr/include/appfw
+includedir=@INCLUDE_INSTALL_DIR@/appfw
 
-Name: @PC_NAME@
-Description: @PACKAGE_DESCRIPTION@
-Version: @VERSION@
-Requires: @PC_REQUIRED@
-Libs: -L${libdir} @PC_LDFLAGS@
+Name: capi-appfw-package-manager
+Description: Package Manager API
+Version: @FULLVER@
+Requires: capi-base-common
+Libs: -L${libdir} -lcapi-appfw-package-manager
 Cflags: -I${includedir}
-