Fix coverity issues

Change-Id: Ia3bcbecc10af6bf2d095680fe6e62860b1fda8ea
Signed-off-by: Boram Bae <boram21.bae@samsung.com>

diff --git a/src/client/sensor_manager.cpp b/src/client/sensor_manager.cpp
index b72580a..10ec56c 100644 (file)
--- a/src/client/sensor_manager.cpp
+++ b/src/client/sensor_manager.cpp
@@ -50,6 +50,7 @@ int sensor_manager::get_sensor(const char *uri, sensor_t *sensor)
 {
        if (!is_supported(uri)) {
                *sensor = NULL;
+               _D("Not supported URI [%s]\n", uri);
                return -ENODATA;
        }
 

diff --git a/src/sensorctl/loopback.cpp b/src/sensorctl/loopback.cpp
index b890f47..aedf77a 100644 (file)
--- a/src/sensorctl/loopback.cpp
+++ b/src/sensorctl/loopback.cpp
@@ -64,8 +64,10 @@ bool loopback_manager::run(int argc, char *argv[])
                for (int i = 4; i < argc; i++)
                        test_data[i+2] = atoi(argv[i]);
 
-               sensord_set_attribute_str(handle, 0, test_data, sizeof(test_data));
-               sensord_disconnect(handle);
+               int error = sensord_set_attribute_str(handle, 0, test_data, sizeof(test_data));
+               WARN_IF(error != 0, "Failed to set attribute\n");
+               bool ret = sensord_disconnect(handle);
+               WARN_IF(ret != true, "Failed to disconnect\n");
                return true;
        }
 
@@ -77,8 +79,10 @@ bool loopback_manager::run(int argc, char *argv[])
 
                char test_data[4] = {SHUB_INST_LIB_REMOVE, SHUB_LOOP_BACK_LIB, };
 
-               sensord_set_attribute_str(handle, 0, test_data, sizeof(test_data));
-               sensord_disconnect(handle);
+               int error = sensord_set_attribute_str(handle, 0, test_data, sizeof(test_data));
+               WARN_IF(error != 0, "Failed to set attribute\n");
+               bool ret = sensord_disconnect(handle);
+               WARN_IF(ret != true, "Failed to disconnect\n");
                return true;
        }
 

diff --git a/src/sensorctl/testcase/sensor_provider.cpp b/src/sensorctl/testcase/sensor_provider.cpp
index 1f5f7d4..8ff3631 100644 (file)
--- a/src/sensorctl/testcase/sensor_provider.cpp
+++ b/src/sensorctl/testcase/sensor_provider.cpp
@@ -116,18 +116,25 @@ static gboolean publish_batch_event(gpointer gdata)
 
 static void add_mysensor(void)
 {
+       int err = 0;
        sensord_provider_h provider = nullptr;
 
-       sensord_create_provider(MYSENSOR_URI, &provider);
-       sensord_provider_set_name(provider, MYSENSOR_NAME);
-       sensord_provider_set_vendor(provider, MYSENSOR_VENDOR);
-       sensord_provider_set_range(provider, 0.0f, 1.0f);
-       sensord_provider_set_resolution(provider, 0.01f);
-
-       sensord_add_provider(provider);
-
-       sensord_remove_provider(provider);
-       sensord_destroy_provider(provider);
+       err = sensord_create_provider(MYSENSOR_URI, &provider);
+       EXPECT_EQ(err, 0);
+       err = sensord_provider_set_name(provider, MYSENSOR_NAME);
+       EXPECT_EQ(err, 0);
+       err = sensord_provider_set_vendor(provider, MYSENSOR_VENDOR);
+       EXPECT_EQ(err, 0);
+       err = sensord_provider_set_range(provider, 0.0f, 1.0f);
+       EXPECT_EQ(err, 0);
+       err = sensord_provider_set_resolution(provider, 0.01f);
+       EXPECT_EQ(err, 0);
+       err = sensord_add_provider(provider);
+       EXPECT_EQ(err, 0);
+       err = sensord_remove_provider(provider);
+       EXPECT_EQ(err, 0);
+       err = sensord_destroy_provider(provider);
+       EXPECT_EQ(err, 0);
 }
 
 static void added_cb(const char *uri, void *user_data)

diff --git a/src/server/sensor_policy_monitor.cpp b/src/server/sensor_policy_monitor.cpp
index 9ab0f2b..8d66d33 100644 (file)
--- a/src/server/sensor_policy_monitor.cpp
+++ b/src/server/sensor_policy_monitor.cpp
@@ -62,14 +62,26 @@ sensor_policy_monitor& sensor_policy_monitor::get_instance(void)
 
 sensor_policy_monitor::sensor_policy_monitor()
 {
-       vconf_notify_key_changed(VCONFKEY_PM_STATE, power_save_state_cb, NULL);
-       vconf_notify_key_changed(VCONFKEY_SETAPPL_PSMODE, power_save_state_cb, NULL);
+       int ret = vconf_notify_key_changed(VCONFKEY_PM_STATE, power_save_state_cb, NULL);
+       if (ret != 0) {
+               _D("Could not add notify callback to VCONFKEY_PM_STATE");
+       }
+       ret = vconf_notify_key_changed(VCONFKEY_SETAPPL_PSMODE, power_save_state_cb, NULL);
+       if (ret != 0) {
+               _D("Could not add notify callback to VCONFKEY_SETAPPL_PSMODE");
+       }
 }
 
 sensor_policy_monitor::~sensor_policy_monitor()
 {
-       vconf_ignore_key_changed(VCONFKEY_PM_STATE, power_save_state_cb);
-       vconf_ignore_key_changed(VCONFKEY_SETAPPL_PSMODE, power_save_state_cb);
+       int ret = vconf_ignore_key_changed(VCONFKEY_PM_STATE, power_save_state_cb);
+       if (ret != 0) {
+               _D("Failed to vconf_ignore_key_changed[VCONFKEY_PM_STATE]");
+       }
+       ret = vconf_ignore_key_changed(VCONFKEY_SETAPPL_PSMODE, power_save_state_cb);
+               if (ret != 0) {
+               _D("Failed to vconf_ignore_key_changed[VCONFKEY_SETAPPL_PSMODE]");
+       }
 }
 
 void sensor_policy_monitor::add_listener(sensor_policy_listener *listener)