Change 'guint' variables to 'gint' and add valid geometry check

[Version] 0.0.28
[Issue type] Bug fix

Change-Id: I494635edc032335fe6014e05d8adcc23fa2c8360

diff --git a/packaging/libmm-evas-renderer.spec b/packaging/libmm-evas-renderer.spec
index 0b7f349..6b28d8c 100644 (file)
--- a/packaging/libmm-evas-renderer.spec
+++ b/packaging/libmm-evas-renderer.spec
@@ -1,6 +1,6 @@
 Name:       libmm-evas-renderer
 Summary:    Multimedia Framework Evas Renderer Library
-Version:    0.0.27
+Version:    0.0.28
 Release:    0
 Group:      Multimedia/Libraries
 License:    Apache-2.0

diff --git a/src/include/mm_evas_renderer_private.h b/src/include/mm_evas_renderer_private.h
index 93cddec..c2079c3 100644 (file)
--- a/src/include/mm_evas_renderer_private.h
+++ b/src/include/mm_evas_renderer_private.h
@@ -99,11 +99,11 @@ typedef struct {
        rect_info dst_roi;
        rect_info result;
        float ratio; /* need to set original ratio, not swap */
-       guint rotate;
-       guint rotate_angle;
-       guint display_geometry_method;
-       guint pre_display_geometry_method;
-       guint flip;
+       gint rotate;
+       gint rotate_angle;
+       gint display_geometry_method;
+       gint pre_display_geometry_method;
+       gint flip;
 
        tbm_surface_h tbm_surf;
 

diff --git a/src/mm_evas_renderer.c b/src/mm_evas_renderer.c
index eb95d2a..5231c13 100644 (file)
--- a/src/mm_evas_renderer.c
+++ b/src/mm_evas_renderer.c
@@ -1473,7 +1473,7 @@ int mm_evas_renderer_set_rotation(MMHandleType handle, int rotate)
 {
        int ret = MM_ERROR_NONE;
        mm_evas_info *evas_info = (mm_evas_info *)handle;
-       guint value;
+       gint value;
 
        MMER_FENTER();
 
@@ -1547,6 +1547,7 @@ int mm_evas_renderer_set_geometry(MMHandleType handle, int mode)
        MMER_FENTER();
 
        MMEVAS_RETURN_VAL_IF_FAIL(evas_info, MM_ERROR_EVASRENDER_NOT_INITIALIZED);
+       MMEVAS_RETURN_VAL_IF_FAIL(mode >= DISP_GEO_METHOD_LETTER_BOX && mode < DISP_GEO_METHOD_NUM, MM_ERROR_EVASRENDER_INVALID_ARGUMENT);
 
        if (evas_info->display_geometry_method != mode) {
                evas_info->update_needed = TRUE;
@@ -1633,7 +1634,7 @@ int mm_evas_renderer_set_flip(MMHandleType handle, int flip)
 {
        int ret = MM_ERROR_NONE;
        mm_evas_info *evas_info = (mm_evas_info *)handle;
-       guint value;
+       gint value;
 
        MMER_FENTER();