[CVE-2016-9842] Avoid shifts of negative values inflateMark(). 74/256474/1 accepted/tizen_6.0_base accepted/tizen_6.0_base_tool tizen_6.0_base accepted/tizen/6.0/base/20230713.143102 accepted/tizen/6.0/base/tool/20210409.094459 submit/tizen_6.0_base/20210405.073145
authorJinWang An <jinwang.an@samsung.com>
Mon, 5 Apr 2021 06:52:49 +0000 (15:52 +0900)
committerJinWang An <jinwang.an@samsung.com>
Mon, 5 Apr 2021 06:52:49 +0000 (15:52 +0900)
The C standard says that bit shifts of negative integers is
undefined.  This casts to unsigned values to assure a known
result.

Change-Id: I217ff9e4407b0627838fc84fd81413098cac0931
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
compat/zlib/inflate.c

index 870f89b..4fd3f3c 100644 (file)
@@ -1504,9 +1504,10 @@ z_streamp strm;
 {
     struct inflate_state FAR *state;
 
-    if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16;
+    if (strm == Z_NULL || strm->state == Z_NULL)
+        return (long)(((unsigned long)0 - 1) << 16);
     state = (struct inflate_state FAR *)strm->state;
-    return ((long)(state->back) << 16) +
+    return (long)(((unsigned long)((long)state->back)) << 16) +
         (state->mode == COPY ? state->length :
             (state->mode == MATCH ? state->was - state->length : 0));
 }