fix dereference without checking and uninitialized data issue

Change-Id: Ieafa8553bcd791f621daa9e9f4715c87d96a5250
Signed-off-by: Jiwoong Im <jiwoong.im@samsung.com>

diff --git a/lib/buxton2.c b/lib/buxton2.c
index 708052f..a221f86 100644 (file)
--- a/lib/buxton2.c
+++ b/lib/buxton2.c
@@ -2112,6 +2112,8 @@ EXPORT int buxton_enable_security_sync(struct buxton_client *client)
        struct bxt_req *req;
        struct response resp;
 
+       memset(&resp, 0, sizeof(resp));
+
        pthread_mutex_lock(&clients_lock);
        req = security_control(client, TRUE, security_sync_cb, &resp);
        if (!req) {
@@ -2157,6 +2159,8 @@ EXPORT int buxton_disable_security_sync(struct buxton_client *client)
        struct bxt_req *req;
        struct response resp;
 
+       memset(&resp, 0, sizeof(resp));
+
        pthread_mutex_lock(&clients_lock);
        req = security_control(client, FALSE, security_sync_cb, &resp);
        if (!req) {
@@ -2253,6 +2257,8 @@ EXPORT int buxton_update_client_label_sync(struct buxton_client *client)
        struct bxt_req *req;
        struct response resp;
 
+       memset(&resp, 0, sizeof(resp));
+
        pthread_mutex_lock(&clients_lock);
        req = update_client_label(client, update_label_sync_cb, &resp);
        if (!req) {

diff --git a/migration/vconf_migration.c b/migration/vconf_migration.c
index 3ade7a4..8580b69 100644 (file)
--- a/migration/vconf_migration.c
+++ b/migration/vconf_migration.c
@@ -54,6 +54,9 @@ static void _get_vconf_keys(const char *path, keylist_t *keylist)
 
        keyname = strrchr(path, '/');
 
+       if (keyname == NULL)
+               goto out_func;
+
        while (*(keyname - 1) != '/')
                keyname--;