Assert against NULL pointer dereference accepted/tizen_9.0_unified tizen_9.0 accepted/tizen/9.0/unified/20241201.053529
authorKarol Lewandowski <k.lewandowsk@samsung.com>
Mon, 25 Nov 2024 17:22:48 +0000 (18:22 +0100)
committerChanwoo Choi <cw00.choi@samsung.com>
Thu, 28 Nov 2024 08:19:44 +0000 (17:19 +0900)
Change-Id: I9cbed8b578abd8b9fe603647529a079cbcfc5811

src/listeners/dbus.c

index b5dc701f2375d2f3d03643d204cbd5c9e62737a3..8da04d822adb0e8375f7d58eedf2f8b0e9e9f486 100644 (file)
@@ -77,6 +77,8 @@ static int parse_message_args(GVariant *m, struct epc_object *params)
        GVariantIter iter;
        GVariant *child;
 
+       assert(NULL != m);
+
        g_variant_iter_init(&iter, m);
        while (1) {
                child = g_variant_iter_next_value(&iter);
@@ -147,6 +149,8 @@ static void on_dbus_signal_match(GDBusConnection *connection,
        struct timespec ts;
        int ret = 0;
 
+       assert(NULL != parameters);
+
        if (clock_gettime(CLOCK_MONOTONIC, &ts) < 0) {
                log_error_errno(errno, "Unable to get timestamp : %m");
                return;
@@ -189,10 +193,8 @@ static void on_dbus_signal_match(GDBusConnection *connection,
                goto finish;
        }
 
-       if(parameters) {
-               g_variant_ref(parameters);
-               ds_ev_data.signal_params = parameters;
-       }
+       g_variant_ref(parameters);
+       ds_ev_data.signal_params = parameters;
 
        ret = epc_event_create(DBUS_SIGNAL_EVENT_ID, &ds_ev_data, &ev);
        if (ret) {