[GS][SVACE] Uninitialized data is read from local variable 'plane' 36/320236/1 tizen_8.0
authorAdam Bujalski <a.bujalski@samsung.com>
Fri, 21 Feb 2025 08:13:04 +0000 (09:13 +0100)
committerj.gajownik2 <j.gajownik2@samsung.com>
Tue, 25 Feb 2025 16:49:13 +0000 (16:49 +0000)
Added variable initialization with invalid and checking that conversion
between enumeration covers all cases.

Bug: https://sa.sec.samsung.net/dm/tizen80/sb2/main/review#PRJID=2&WGID=89464
Bug: DF240128-00041
Bug: https://jira-eu.sec.samsung.net/browse/VDWASM-2260
Signed-off-by: Adam Bujalski <a.bujalski@samsung.com>
Change-Id: Iaf898cc9361d181913c30fa2dfa5dd96546044aa

tizen_src/chromium_impl/ui/ozone/platform/efl/output_surface_impl.cc

index ee1a7c51ea4ba17e5c73376ae7789be4e96f24e8..be4e24504137308eef95a15b972c29ff3aa7c814 100644 (file)
@@ -514,7 +514,7 @@ void OutputSurfaceImpl::OnInputSourceChanged() {
 }
 
 std::pair<bool, bool> OutputSurfaceImpl::IsPlaneVisible() {
-  IVideoDpControl::VideoPlaneType plane;
+  IVideoDpControl::VideoPlaneType plane = IVideoDpControl::VIDEO_PLANE_MAX;
   switch (plane_) {
     case OutputSurface::Plane::kMain:
       plane = IVideoDpControl::VIDEO_PLANE_DP_MAIN;
@@ -530,6 +530,11 @@ std::pair<bool, bool> OutputSurfaceImpl::IsPlaneVisible() {
       break;
   }
 
+  if (plane == IVideoDpControl::VIDEO_PLANE_MAX) {
+    TIZEN_MEDIA_LOG(ERROR) << "Unknown plane: " << static_cast<int>(plane_);
+    return {true, false};
+  }
+
   IVideoDpControl::TZTVPlaneMuteSync value;
   if (IVideoDpControl::getInstance()->getVideoPlaneMuteSyncStatus(
           plane, &value) != 0) {