Fix coverity issue 45/308545/1 tizen_8.0
authorYoungHun Kim <yh8004.kim@samsung.com>
Tue, 26 Mar 2024 05:09:32 +0000 (14:09 +0900)
committerYoungHun Kim <yh8004.kim@samsung.com>
Wed, 27 Mar 2024 08:00:32 +0000 (08:00 +0000)
 - Add the return value

Change-Id: Ib5353e80df39ba12affec9feeb61facbd5c97b28

packaging/mm-resource-manager.spec
src/daemon/mm_resource_manager_daemon_priv.c
src/lib/mm_resource_manager_priv.c

index 0243faf19f86b747ec923b71777692c8cf9f4d14..d6cdc6068d0eb55cc58c2f3ed5aee8dedf262fbf 100644 (file)
@@ -1,6 +1,6 @@
 Name:       mm-resource-manager
 Summary:    A Multimedia Resource Manager API
-Version:    0.2.56
+Version:    0.2.57
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index 096e69f28640dbd79b82fa082c658c4795247692..9bd6ebf4b35afdeb62c29dea5e7ace2c892cf21e 100644 (file)
@@ -129,24 +129,31 @@ gboolean _mmrm_dmn_deinit(void)
 {
        int i;
 
-       if (mm_resource_manager_backend_deinit() != MM_RESOURCE_MANAGER_ERROR_NONE)
+       if (mm_resource_manager_backend_deinit() != MM_RESOURCE_MANAGER_ERROR_NONE) {
                MM_RM_ERROR("Error during back-end deinitialization");
+               return FALSE;
+       }
 
-       if (_mmrm_dmn_dbus_deinit() != MM_RESOURCE_MANAGER_ERROR_NONE)
+       if (_mmrm_dmn_dbus_deinit() != MM_RESOURCE_MANAGER_ERROR_NONE) {
                MM_RM_ERROR("Error during d-bus server shutdown");
+               return FALSE;
+       }
 
        if (managers) {
                for (i = 0; i < managers->len; i++)
                        __destroy_all_resources((mm_resource_manager_dmn_p)managers->pdata[i]);
 
                mm_resource_manager_backend_commit_all();
-               g_ptr_array_free(managers, TRUE);
+               managers = (GPtrArray *)g_ptr_array_free(managers, TRUE);
        } else {
                MM_RM_ERROR("Trying to deinit uninitialized daemon");
+               return FALSE;
        }
 
-       if (unlink(RELEASE_CB_SYNC_PATH) == -1)
+       if (unlink(RELEASE_CB_SYNC_PATH) == -1) {
                MM_RM_ERROR("Release callback sync cannot be removed");
+               return FALSE;
+       }
 
        return TRUE;
 }
index c1cbfa468480e38811e61a5b9742acc0db2b2e9c..0e8c8ca9e4c1be79552f1837aec322d07e5efefd 100644 (file)
@@ -226,7 +226,7 @@ int _mm_resource_manager_destroy(mm_resource_manager_h rm)
 
        __destroy_dispatcher(handle);
 
-       g_ptr_array_free(handle->resources, TRUE);
+       handle->resources = (GPtrArray *)g_ptr_array_free(handle->resources, TRUE);
        __mm_resources_unlock(handle);
 
        g_mutex_clear(&handle->resources_lock);
@@ -848,7 +848,7 @@ static void __deinit_lib()
                        _mm_resource_manager_destroy(handles->pdata[0]);
        }
 
-       g_ptr_array_free(handles, TRUE);
+       handles = (GPtrArray *)g_ptr_array_free(handles, TRUE);
 
        MM_RM_INFO("API lib is unloaded");
 }