Fix GlobalVariable violation

SAM Score: 3.71 -> 4.38
GV: 0.85 -> 5

[Version] 0.1.42
[Issue Type] SAM

Change-Id: Ic807e9faeaaaf7eb5b7c5b5360b83b6480736fec

diff --git a/packaging/capi-mediademuxer.spec b/packaging/capi-mediademuxer.spec
index 2e603648680d936931f34df17059abe1e929bda5..43d89d438e7a3215bda31c70101eb8da9ba56139 100644 (file)
--- a/packaging/capi-mediademuxer.spec
+++ b/packaging/capi-mediademuxer.spec
@@ -1,6 +1,6 @@
 Name:       capi-mediademuxer
 Summary:    A Media Demuxer library in Tizen Native API
-Version:    0.1.41
+Version:    0.1.42
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0

diff --git a/src/mediademuxer_port.c b/src/mediademuxer_port.c
index a8b4750b108f5659c2f8808906d4c84e8bf55422..f753b40ad0d780c0025bb98a2dd215dbce259a5f 100644 (file)
--- a/src/mediademuxer_port.c
+++ b/src/mediademuxer_port.c
@@ -49,7 +49,7 @@ int _md_util_parse(MMHandleType demuxer, const char *type);
   * "port_mode" in mm_demuxer_ini.h file
   */
 typedef int (*register_port_demuxer)(media_port_demuxer_ops *);
-register_port_demuxer register_port_demuxer_func[] = {
+static register_port_demuxer register_port_demuxer_func[] = {
        &gst_mediademxer_port_register,
        &ffmpeg_mediademxer_port_register,
        &custom_mediademxer_port_register

diff --git a/test/mediademuxer_test.c b/test/mediademuxer_test.c
index b39721d8fb6ff7a53c6053bcce83a2b869d25d13..1bb1c46240b4baf546eb5cf4e4921854b3abc736 100644 (file)
--- a/test/mediademuxer_test.c
+++ b/test/mediademuxer_test.c
@@ -48,25 +48,25 @@ enum {
 /*-----------------------------------------------------------------------
 |    GLOBAL VARIABLE DEFINITIONS:                                       |
 -----------------------------------------------------------------------*/
-mediademuxer_h demuxer = NULL;
-media_format_mimetype_e v_mime;
-media_format_mimetype_e a_mime;
-media_format_mimetype_e t_mime;
-media_format_text_type_e t_type;
-int g_menu_state = CURRENT_STATUS_MAINMENU;
-int num_tracks = 0;
-int aud_track = -1;
-int vid_track = -1;
-int txt_track = -1;
-int w;
-int h;
-int channel = 0;
-int samplerate = 0;
-int bit = 0;
-bool is_adts = 0;
-bool vid_eos_track = 0;
-bool aud_eos_track = 0;
-bool text_eos_track = 0;
+static mediademuxer_h demuxer = NULL;
+static media_format_mimetype_e v_mime;
+static media_format_mimetype_e a_mime;
+static media_format_mimetype_e t_mime;
+static media_format_text_type_e t_type;
+static int g_menu_state = CURRENT_STATUS_MAINMENU;
+static int num_tracks = 0;
+static int aud_track = -1;
+static int vid_track = -1;
+static int txt_track = -1;
+static int w;
+static int h;
+static int channel = 0;
+static int samplerate = 0;
+static int bit = 0;
+static bool is_adts = 0;
+static bool vid_eos_track = 0;
+static bool aud_eos_track = 0;
+static bool text_eos_track = 0;
 
 /*-----------------------------------------------------------------------
 |    DEBUG DEFINITIONS                                                            |
@@ -116,29 +116,29 @@ bool text_eos_track = 0;
 #define DEMUXER_OUTPUT_DUMP         1
 
 #if DEMUXER_OUTPUT_DUMP
-FILE *fp_audio_out = NULL;
-FILE *fp_video_out = NULL;
-FILE *fp_text_out = NULL;
-bool validate_dump = false;
+static FILE *fp_audio_out = NULL;
+static FILE *fp_video_out = NULL;
+static FILE *fp_text_out = NULL;
+static bool validate_dump = false;
 
 #define ADTS_HEADER_SIZE            7
-unsigned char buf_adts[ADTS_HEADER_SIZE];
+static unsigned char buf_adts[ADTS_HEADER_SIZE];
 
 #define AMR_NB_MIME_HDR_SIZE          6
 #define AMR_WB_MIME_HDR_SIZE          9
 static const char AMRNB_HDR[] = "#!AMR\n";
 static const char AMRWB_HDR[] = "#!AMR-WB\n";
-int write_amrnb_header = 0;    /* write  magic number for AMR-NB Header at one time */
-int write_amrwb_header = 0;    /* write  magic number for AMR-WB Header at one time */
+static int write_amrnb_header = 0;     /* write  magic number for AMR-NB Header at one time */
+static int write_amrwb_header = 0;     /* write  magic number for AMR-WB Header at one time */
 #endif
 
-bool validate_with_codec = false;
+static bool validate_with_codec = false;
 
-FILE *fp_out_codec_audio = NULL;
-FILE *fp_out_codec_video = NULL;
 #ifdef USE_MEDIA_CODEC
-mediacodec_h g_media_codec = NULL;
-mediacodec_h g_media_codec_1 = NULL;
+static FILE *fp_out_codec_audio = NULL;
+static FILE *fp_out_codec_video = NULL;
+static mediacodec_h g_media_codec = NULL;
+static mediacodec_h g_media_codec_1 = NULL;
 #endif
 
 /*-----------------------------------------------------------------------