Fix strncat bug 88/279688/4 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/20221110.061528 accepted/tizen/7.0/unified/hotfix/20221116.105500 accepted/tizen/unified/20220824.135613 submit/tizen/20220824.005052 tizen_7.0_m2_release
authorKwanghoon Son <k.son@samsung.com>
Tue, 16 Aug 2022 07:18:01 +0000 (03:18 -0400)
committerKwanghoon Son <k.son@samsung.com>
Wed, 17 Aug 2022 04:50:09 +0000 (00:50 -0400)
[Version] : 0.0.6
[Issue type] : Bug fix

sizeof return architecture pointer size.
Change it to snprintf

Change-Id: I5ff9a2b175f180516cefc459058fd059c23b7ff1
Signed-off-by: Kwanghoon Son <k.son@samsung.com>
packaging/vision-source.spec
src/vision_source.c

index d7735d97403fb6657713c547f7624946f02de9f5..43d9f4a9e894c90e72585b15eda4afad27842d2b 100644 (file)
@@ -1,6 +1,6 @@
 Name:        vision-source
 Summary:     vision source
-Version:     0.0.6
+Version:     0.0.7
 Release:     0
 Group:       Multimedia/Framework
 License:     Apache-2.0
index 5983538b70fe002e23d794f7434533c8dcfdc6b0..acf2e19764ad2fcc09a485152c5dcd9a8d303105 100644 (file)
@@ -56,6 +56,8 @@ int _vision_source_dlsym(vision_source_internal_s *handle)
 int _vision_source_attach(const char *backend_name,
                                                  vision_source_internal_s *handle)
 {
+       LOGD("ENTER");
+       LOGI("backend %s connected", backend_name);
        handle->dl_handle = dlopen(backend_name, RTLD_LAZY);
        VISION_SOURCE_NULL_ARG_CHECK(handle->dl_handle);
 
@@ -64,11 +66,13 @@ int _vision_source_attach(const char *backend_name,
                dlclose(handle->dl_handle);
                return ret;
        }
+       LOGD("EXIT");
        return VISION_SOURCE_ERROR_NONE;
 }
 
 int _vision_source_get_backend(char *name)
 {
+       LOGD("ENTER");
        dictionary *ini = iniparser_load(INI_PATH);
        if (ini == NULL) {
                return VISION_SOURCE_ERROR_INVALID_PARAMETER;
@@ -80,21 +84,21 @@ int _vision_source_get_backend(char *name)
                return VISION_SOURCE_ERROR_INVALID_PARAMETER;
        }
 
-       strncat(name, backend_name, sizeof(backend_name));
-       const char *suffix = ".so";
-       strncat(name, suffix, sizeof(suffix));
+       snprintf(name, MAX_BACKEND_NAME, "libvision-source-%s.so", backend_name);
 
        iniparser_freedict(ini);
+       LOGD("EXIT");
        return VISION_SOURCE_ERROR_NONE;
 }
 
 int vision_source_init(vision_source_h *handle)
 {
+       LOGD("ENTER");
        VISION_SOURCE_NULL_ARG_CHECK(handle);
 
        vision_source_internal_s *source_handle = NULL;
 
-       char backend_tmp[MAX_BACKEND_NAME] = { "libvision-source-" };
+       char backend_tmp[MAX_BACKEND_NAME];
        int ret = _vision_source_get_backend(backend_tmp);
        if (ret != VISION_SOURCE_ERROR_NONE) {
                return ret;
@@ -111,11 +115,13 @@ int vision_source_init(vision_source_h *handle)
        }
        *handle = source_handle;
 
+       LOGD("EXIT");
        return VISION_SOURCE_ERROR_NONE;
 }
 
 int vision_source_exit(vision_source_h handle)
 {
+       LOGD("ENTER");
        VISION_SOURCE_NULL_ARG_CHECK(handle);
        vision_source_internal_s *source_handle =
                        (vision_source_internal_s *) handle;
@@ -133,6 +139,7 @@ int vision_source_exit(vision_source_h handle)
        }
 
        free(source_handle);
+       LOGD("EXIT");
        return VISION_SOURCE_ERROR_NONE;
 }