Fix coverity issue 69/245169/1 accepted/tizen_6.0_unified accepted/tizen_6.0_unified_hotfix accepted/tizen_6.5_unified tizen_6.0 tizen_6.0_hotfix tizen_6.5 accepted/tizen/6.0/unified/20201030.114039 accepted/tizen/6.0/unified/hotfix/20201103.002227 accepted/tizen/6.5/unified/20211028.120454 accepted/tizen/unified/20201005.101356 submit/tizen/20201005.072910 submit/tizen_6.0/20201029.205105 submit/tizen_6.0_hotfix/20201102.192505 submit/tizen_6.0_hotfix/20201103.114805 submit/tizen_6.5/20211028.162501 tizen_6.0.m2_release tizen_6.5.m2_release
authorWootak Jung <wootak.jung@samsung.com>
Mon, 5 Oct 2020 04:56:05 +0000 (13:56 +0900)
committerWootak Jung <wootak.jung@samsung.com>
Mon, 5 Oct 2020 05:25:37 +0000 (14:25 +0900)
Change-Id: I0f2ca17f1177f6aca1ed3caa30c8e474ccb2f86a
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
src/call-manager.c

index c6b74bc68f409607f412e960bbb04f0b143d37e9..71e63deb903ae35944a34895e13400ad13e44d17 100644 (file)
@@ -519,14 +519,16 @@ EXPORT_API int cm_dial_call(cm_client_h handle, char*number, cm_call_type_e call
                        value = CM_ERROR_OPERATION_FAILED;
                }
        } else {
-               err("g_dbus_conn failed. error (%s)", error->message);
-               if (strstr(error->message, "No access rights")) {
-                       err("PERMISSION_DENIED");
-                       value = CM_ERROR_PERMISSION_DENIED;
-               } else {
-                       value = CM_ERROR_OPERATION_FAILED;
+               if (error) {
+                       err("g_dbus_conn failed. error (%s)", error->message);
+                       if (strstr(error->message, "No access rights")) {
+                               err("PERMISSION_DENIED");
+                               value = CM_ERROR_PERMISSION_DENIED;
+                       } else {
+                               value = CM_ERROR_OPERATION_FAILED;
+                       }
+                       g_error_free(error);
                }
-               g_error_free(error);
        }
 
         g_variant_unref(dbus_result);
@@ -586,14 +588,16 @@ EXPORT_API int cm_reject_call(cm_client_h handle)
                        value = CM_ERROR_OPERATION_FAILED;
                }
        } else {
-               err("g_dbus_conn failed. error (%s)", error->message);
-               if (strstr(error->message, "No access rights")) {
-                       err("PERMISSION_DENIED");
-                       value = CM_ERROR_PERMISSION_DENIED;
-               } else {
-                       value = CM_ERROR_OPERATION_FAILED;
+               if (error) {
+                       err("g_dbus_conn failed. error (%s)", error->message);
+                       if (strstr(error->message, "No access rights")) {
+                               err("PERMISSION_DENIED");
+                               value = CM_ERROR_PERMISSION_DENIED;
+                       } else {
+                               value = CM_ERROR_OPERATION_FAILED;
+                       }
+                       g_error_free(error);
                }
-               g_error_free(error);
        }
 
        g_variant_unref(dbus_result);
@@ -1317,14 +1321,16 @@ EXPORT_API int cm_stop_alert(cm_client_h handle)
                        value = CM_ERROR_OPERATION_FAILED;
                }
        } else {
-               err("g_dbus_conn failed. error (%s)", error->message);
-               if (strstr(error->message, "No access rights")) {
-                       err("PERMISSION_DENIED");
-                       value = CM_ERROR_PERMISSION_DENIED;
-               } else {
-                       value = CM_ERROR_OPERATION_FAILED;
+               if (error) {
+                       err("g_dbus_conn failed. error (%s)", error->message);
+                       if (strstr(error->message, "No access rights")) {
+                               err("PERMISSION_DENIED");
+                               value = CM_ERROR_PERMISSION_DENIED;
+                       } else {
+                               value = CM_ERROR_OPERATION_FAILED;
+                       }
+                       g_error_free(error);
                }
-               g_error_free(error);
        }
 
        g_variant_unref(dbus_result);
@@ -1353,14 +1359,16 @@ EXPORT_API int cm_start_alert(cm_client_h handle)
                        value = CM_ERROR_OPERATION_FAILED;
                }
        } else {
-               err("g_dbus_conn failed. error (%s)", error->message);
-               if (strstr(error->message, "No access rights")) {
-                       err("PERMISSION_DENIED");
-                       value = CM_ERROR_PERMISSION_DENIED;
-               } else {
-                       value = CM_ERROR_OPERATION_FAILED;
+               if (error) {
+                       err("g_dbus_conn failed. error (%s)", error->message);
+                       if (strstr(error->message, "No access rights")) {
+                               err("PERMISSION_DENIED");
+                               value = CM_ERROR_PERMISSION_DENIED;
+                       } else {
+                               value = CM_ERROR_OPERATION_FAILED;
+                       }
+                       g_error_free(error);
                }
-               g_error_free(error);
        }
 
        g_variant_unref(dbus_result);
@@ -1648,14 +1656,16 @@ EXPORT_API int cm_get_call_status(cm_client_h handle, cm_call_status_e *call_sta
                        error_code = CM_ERROR_OPERATION_FAILED;
                }
        } else {
-               err("g_dbus_conn failed. error (%s)", error->message);
-               if (strstr(error->message, "No access rights")) {
-                       err("PERMISSION_DENIED");
-                       error_code = CM_ERROR_PERMISSION_DENIED;
-               } else {
-                       error_code = CM_ERROR_OPERATION_FAILED;
+               if (error) {
+                       err("g_dbus_conn failed. error (%s)", error->message);
+                       if (strstr(error->message, "No access rights")) {
+                               err("PERMISSION_DENIED");
+                               error_code = CM_ERROR_PERMISSION_DENIED;
+                       } else {
+                               error_code = CM_ERROR_OPERATION_FAILED;
+                       }
+                       g_error_free(error);
                }
-               g_error_free(error);
        }
 
        g_variant_unref(dbus_result);
@@ -1688,14 +1698,16 @@ EXPORT_API int cm_get_mute_status(cm_client_h handle, cm_mute_status_e *mute_sta
                        error_code = CM_ERROR_OPERATION_FAILED;
                }
        } else {
-               err("g_dbus_conn failed. error (%s)", error->message);
-               if (strstr(error->message, "No access rights")) {
-                       err("PERMISSION_DENIED");
-                       error_code = CM_ERROR_PERMISSION_DENIED;
-               } else {
-                       error_code = CM_ERROR_OPERATION_FAILED;
+               if (error) {
+                       err("g_dbus_conn failed. error (%s)", error->message);
+                       if (strstr(error->message, "No access rights")) {
+                               err("PERMISSION_DENIED");
+                               error_code = CM_ERROR_PERMISSION_DENIED;
+                       } else {
+                               error_code = CM_ERROR_OPERATION_FAILED;
+                       }
+                       g_error_free(error);
                }
-               g_error_free(error);
        }
 
        g_variant_unref(dbus_result);