Fix coverity issue (Uninitialized pointer read)

[Version] 0.0.4
[Issue Type] Coverity

Change-Id: Ibc940271aab502ed155c67036daac2cf3c6a72aa
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>

diff --git a/packaging/rnnoise.spec b/packaging/rnnoise.spec
index 96a9937..275cc78 100644 (file)
--- a/packaging/rnnoise.spec
+++ b/packaging/rnnoise.spec
@@ -1,7 +1,7 @@
 %global date 20210312
 Name:       rnnoise
 Version:    0
-Release:    0.3
+Release:    0.4
 Summary:    Recurrent neural network for audio noise reduction
 License:    BSD-3-Clause
 URL:        https://gitlab.xiph.org/xiph/rnnoise
@@ -27,7 +27,7 @@ Requires:   %{name}%{?_isa} = %{version}-%{release}
 Devel files for %{name}.
 
 %prep
-%autosetup -n %{name}-%{version}.%{date} -p1
+%setup -q
 cp %{SOURCE1} .
 
 cat > 'package_version' <<-EOF

diff --git a/src/kiss_fft.c b/src/kiss_fft.c
index d6b9f26..033cea0 100644 (file)
--- a/src/kiss_fft.c
+++ b/src/kiss_fft.c
@@ -449,6 +449,7 @@ kiss_fft_state *opus_fft_alloc_twiddles(int nfft,void * mem,size_t * lenmem,
         kiss_twiddle_cpx *twiddles;
 
         st->nfft=nfft;
+        st->bitrev = NULL;
 #ifdef FIXED_POINT
         st->scale_shift = celt_ilog2(st->nfft);
         if (st->nfft == 1<<st->scale_shift)
@@ -506,7 +507,8 @@ void opus_fft_free(const kiss_fft_state *cfg, int arch)
    if (cfg)
    {
       opus_fft_free_arch((kiss_fft_state *)cfg, arch);
-      opus_free((opus_int16*)cfg->bitrev);
+      if (cfg->bitrev)
+         opus_free((opus_int16*)cfg->bitrev);
       if (cfg->shift < 0)
          opus_free((kiss_twiddle_cpx*)cfg->twiddles);
       opus_free((kiss_fft_state*)cfg);