Fix coverity issue

 - Add the return value

Change-Id: Ib5353e80df39ba12affec9feeb61facbd5c97b28

diff --git a/packaging/mm-resource-manager.spec b/packaging/mm-resource-manager.spec
index aa6ea0d..99bdf77 100644 (file)
--- a/packaging/mm-resource-manager.spec
+++ b/packaging/mm-resource-manager.spec
@@ -1,6 +1,6 @@
 Name:       mm-resource-manager
 Summary:    A Multimedia Resource Manager API
-Version:    0.2.56
+Version:    0.2.57
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0

diff --git a/src/daemon/mm_resource_manager_daemon_priv.c b/src/daemon/mm_resource_manager_daemon_priv.c
index 096e69f..9bd6ebf 100644 (file)
--- a/src/daemon/mm_resource_manager_daemon_priv.c
+++ b/src/daemon/mm_resource_manager_daemon_priv.c
@@ -129,24 +129,31 @@ gboolean _mmrm_dmn_deinit(void)
 {
        int i;
 
-       if (mm_resource_manager_backend_deinit() != MM_RESOURCE_MANAGER_ERROR_NONE)
+       if (mm_resource_manager_backend_deinit() != MM_RESOURCE_MANAGER_ERROR_NONE) {
                MM_RM_ERROR("Error during back-end deinitialization");
+               return FALSE;
+       }
 
-       if (_mmrm_dmn_dbus_deinit() != MM_RESOURCE_MANAGER_ERROR_NONE)
+       if (_mmrm_dmn_dbus_deinit() != MM_RESOURCE_MANAGER_ERROR_NONE) {
                MM_RM_ERROR("Error during d-bus server shutdown");
+               return FALSE;
+       }
 
        if (managers) {
                for (i = 0; i < managers->len; i++)
                        __destroy_all_resources((mm_resource_manager_dmn_p)managers->pdata[i]);
 
                mm_resource_manager_backend_commit_all();
-               g_ptr_array_free(managers, TRUE);
+               managers = (GPtrArray *)g_ptr_array_free(managers, TRUE);
        } else {
                MM_RM_ERROR("Trying to deinit uninitialized daemon");
+               return FALSE;
        }
 
-       if (unlink(RELEASE_CB_SYNC_PATH) == -1)
+       if (unlink(RELEASE_CB_SYNC_PATH) == -1) {
                MM_RM_ERROR("Release callback sync cannot be removed");
+               return FALSE;
+       }
 
        return TRUE;
 }

diff --git a/src/lib/mm_resource_manager_priv.c b/src/lib/mm_resource_manager_priv.c
index c1cbfa4..0e8c8ca 100644 (file)
--- a/src/lib/mm_resource_manager_priv.c
+++ b/src/lib/mm_resource_manager_priv.c
@@ -226,7 +226,7 @@ int _mm_resource_manager_destroy(mm_resource_manager_h rm)
 
        __destroy_dispatcher(handle);
 
-       g_ptr_array_free(handle->resources, TRUE);
+       handle->resources = (GPtrArray *)g_ptr_array_free(handle->resources, TRUE);
        __mm_resources_unlock(handle);
 
        g_mutex_clear(&handle->resources_lock);
@@ -848,7 +848,7 @@ static void __deinit_lib()
                        _mm_resource_manager_destroy(handles->pdata[0]);
        }
 
-       g_ptr_array_free(handles, TRUE);
+       handles = (GPtrArray *)g_ptr_array_free(handles, TRUE);
 
        MM_RM_INFO("API lib is unloaded");
 }