Fix defects detected by static analysis tool

[Problem] [TNINE-4742] Issues detected by Static Analysis Tool
[Cause & Measure]
 Cause   : Assembly was not loaded properly.
 Measure : Loaded Assembly File Properly.

Change-Id: Icbe46b55db00741ddbc8728937ca72767454afac
Signed-off-by: CORP\mobaswirul.i <mobaswirul.i@samsung.com>

diff --git a/SettingCore/GadgetProvider.cs b/SettingCore/GadgetProvider.cs
index 78789cf1a929a55ea5d43e10149d86311f30853b..acf514e88a309eddbbb0e8f8dc52a42ec2ba8b66 100644 (file)
--- a/SettingCore/GadgetProvider.cs
+++ b/SettingCore/GadgetProvider.cs
@@ -64,12 +64,11 @@ namespace SettingCore
         private static IEnumerable<SettingGadgetInfo> getSettingGadgetInfos(NUIGadgetInfo gadgetInfo)
         {
             string assemblyPath = System.IO.Path.Combine(gadgetInfo.ResourcePath, gadgetInfo.ExecutableFile);
-            byte[] fileData = System.IO.File.ReadAllBytes(assemblyPath);
             Assembly assembly = null;
             try
             {
                 Logger.Verbose($"Opening assembly from {assemblyPath} ({gadgetInfo.ResourcePath}, {gadgetInfo.ExecutableFile})");
-                assembly = System.Reflection.Assembly.Load(fileData);
+                assembly = Assembly.Load(AssemblyName.GetAssemblyName(assemblyPath));
             }
             catch (System.IO.FileLoadException)
             {

diff --git a/packaging/org.tizen.cssettings-1.2.4.tpk b/packaging/org.tizen.cssettings-1.2.4.tpk
index bc1bb8f317c16155b749733ba25a5c14a56897d1..2160e300566b1a987e82866e8b3bdc120c1b6437 100644 (file)
Binary files a/packaging/org.tizen.cssettings-1.2.4.tpk and b/packaging/org.tizen.cssettings-1.2.4.tpk differ