fix warning from strndup()

- revert build option, Wno-stringop-overread

Change-Id: Ie7e526f2e8c67bd5935be720350fe48b28d3a4d4
Signed-off-by: KiseokChang <kiso.chang@samsung.com>

diff --git a/setting-ringtone/CMakeLists.txt b/setting-ringtone/CMakeLists.txt
index 4b9466400949eba2575cb6dbfc67fe44f87db5d8..cd00fd3d1f059eea34f51676fe5fbadb8acdab45 100755 (executable)
--- a/setting-ringtone/CMakeLists.txt
+++ b/setting-ringtone/CMakeLists.txt
@@ -35,6 +35,7 @@ ENDIF("${ARCH}" STREQUAL "arm")
 ADD_DEFINITIONS("-DPREFIX=\"${CMAKE_INSTALL_PREFIX}\"")
 ADD_DEFINITIONS("-DSLP_DEBUG")
 ADD_DEFINITIONS("-shared")
+ADD_DEFINITIONS("-Wno-stringop-overread")
 
 SET(CMAKE_EXE_LINKER_FLAGS "-Wl,--as-needed -Wl,--rpath=/usr/lib")
 

diff --git a/setting-ringtone/src/setting-ringtone-main.c b/setting-ringtone/src/setting-ringtone-main.c
index 95d36fd89f4b4c18bba35616fdd6a9bf1b5a10c0..9706a8dd00ef6ba7cd561850cbdd1cef12add024 100755 (executable)
--- a/setting-ringtone/src/setting-ringtone-main.c
+++ b/setting-ringtone/src/setting-ringtone-main.c
@@ -351,10 +351,14 @@ static char *_get_default_filepath(SettingRingtoneData *ad)
        if (ad->default_substitution)
                return strndup(ad->default_substitution, PATH_MAX);
 
+       int maxpath = sizeof(ALERT_FILE_PATH_DEF);
+       if(maxpath > PATH_MAX) maxpath = PATH_MAX;
        if (ad->show_notification)
-               return strndup(ALERT_FILE_PATH_DEF, PATH_MAX);
+               return strndup(ALERT_FILE_PATH_DEF, maxpath);
 
-       return strndup(RINGTONE_FILE_PATH_DEF, PATH_MAX);
+       maxpath = sizeof(RINGTONE_FILE_PATH_DEF);
+       if(maxpath > PATH_MAX) maxpath = PATH_MAX;
+       return strndup(RINGTONE_FILE_PATH_DEF, maxpath);
 }
 
 static void _move_more_ctxpopup(SettingRingtoneData *ad)