Fixing Noise in changing volume. 36/284136/1 accepted/tizen_unified tizen accepted/tizen/unified/20221111.164307
authorshivam.v2 <shivam.v2@samsung.com>
Thu, 10 Nov 2022 08:51:39 +0000 (14:21 +0530)
committershivam.v2 <shivam.v2@samsung.com>
Thu, 10 Nov 2022 08:51:39 +0000 (14:21 +0530)
Change-Id: If76543c9dcfc9a536187ae720ca7afe4c3bde06b
Signed-off-by: shivam.v2 <shivam.v2@samsung.com>
inc/sound.h
src/sound.c
src/view.c

index 5135c6b32cf97a4edcd6bb12ef9e7879cd6a1dad..478608951f7603ba00f671e87ecb39cf74f8e94f 100755 (executable)
@@ -35,7 +35,7 @@ extern void volume_sound_play(void);
 extern int volume_sound_icon_set(void *data, int val);
 extern int volume_sound_level_set(sound_type_e type, int val);
 extern void volume_sound_setting_sound_play(void);
-extern void volume_sound_change_set(int val);
+extern void volume_sound_change_set(int val, bool sound_required);
 
 extern void volume_sound_vconf_status_set(volume_vconf_type_e type, int val);
 extern int volume_sound_vconf_status_get(volume_vconf_type_e type);
index e27ce2b77b43fa7e3a84b099de969aaa22df82ac..f051cfbd3b9919c749b61bf8e82f3407036f7563 100755 (executable)
@@ -210,7 +210,7 @@ int volume_sound_level_set(sound_type_e type, int val)
        return ret;
 }
 
-void volume_sound_change_set(int val)
+void volume_sound_change_set(int val, bool sound_required)
 {
        sound_type_e sound_type = volume_control_get_sound_type_at_show();
        _D("sound type at show : %d", sound_type);
@@ -227,8 +227,10 @@ void volume_sound_change_set(int val)
                }
                if (volume_sound_level_set(sound_type, val) != 0)
                        volume_sound_level_set(sound_type, 9);
-
-               volume_sound_play();
+               if (sound_required)
+               {
+                       volume_sound_play();
+               }
        } else {
                if (sound_type != SOUND_TYPE_MEDIA)
                        volume_sound_vconf_status_set(TYPE_VCONF_SOUND_STATUS, 0);
index ee9d5f64fed5a2a846e343959114c36dce3f6e14..664301a1dbb78fab257ceebcef8e968699a31d68 100755 (executable)
@@ -804,10 +804,15 @@ static void _slider_changed_cb(void *data, Evas_Object *obj, void *event_info)
        val = elm_slider_value_get(view_info.slider);
        val += 0.5;
        _D("slider value : %lf", val);
-
-       volume_sound_change_set((int)val);
-
        volume_timer_add(3.0, TYPE_TIMER_POPUP);
+       if (view_info.is_slider_touching)
+       {
+               volume_sound_change_set((int)val, false);
+       }
+       else
+       {
+               volume_sound_change_set((int)val, true);
+       }
 }
 
 static void _slider_stop_cb(void *data, Evas_Object *obj, void *event_info)
@@ -825,7 +830,7 @@ static void _slider_stop_cb(void *data, Evas_Object *obj, void *event_info)
        val += 0.5;
        _D("slider value : %d", (int)val);
 
-       volume_sound_change_set((int)val);
+       volume_sound_change_set((int)val, true);
 
        volume_timer_add(3.0, TYPE_TIMER_POPUP);
 }