Fix Toolchain(GCC-9)

Change-Id: I76c2a4754add976c08357d7689611acdc5742c83
Signed-off-by: cookie <cookie@samsung.com>

diff --git a/core/AbstractWebEngine/WebConfirmation.cpp b/core/AbstractWebEngine/WebConfirmation.cpp
index 6d446f74fe5b7f810be30794f0bc485ed1b8d042..99f5cef720fd91d6c638a63c0120aa02da630a37 100644 (file)
--- a/core/AbstractWebEngine/WebConfirmation.cpp
+++ b/core/AbstractWebEngine/WebConfirmation.cpp
@@ -36,6 +36,7 @@ WebConfirmation::WebConfirmation(ConfirmationType type, TabId tabId, const std::
     , m_tabId(tabId)
     , m_uri(uri)
     , m_message(msg)
+    , m_result(None)
 {
 }
 
@@ -45,6 +46,7 @@ WebConfirmation::~WebConfirmation()
 
 CertificateConfirmation::CertificateConfirmation(TabId tabId, const std::string & uri, const std::string & msg)
     : WebConfirmation(ConfirmationType::CertificateConfirmation, tabId, uri, msg)
+    , m_data(nullptr)
 {
 }
 

diff --git a/core/BrowserLogger.h b/core/BrowserLogger.h
index ba620f6269a61d090ba093811a88bd38b9d99d55..20692c5ab8057a18f5738c3d795d41370da9415b 100644 (file)
--- a/core/BrowserLogger.h
+++ b/core/BrowserLogger.h
@@ -20,7 +20,7 @@
 #include "browser_config.h"
 #include <string>
 
-#if !defined(NDEBUG) || PLATFORM(TIZEN)
+#ifdef NDEBUG
 
 #include "Logger/Logger.h"
 

diff --git a/core/Logger/LoggerTools.cpp b/core/Logger/LoggerTools.cpp
index ce11275098f4d50ca3d95de615a27ac437d34845..5c33738c46b34eb666800ac16e97c33cd0edef2c 100644 (file)
--- a/core/Logger/LoggerTools.cpp
+++ b/core/Logger/LoggerTools.cpp
@@ -36,7 +36,7 @@ std::string make_message(const char *fmt, ...)
 
        try {
                p = new char[size];
-       } catch (std::bad_alloc) {
+       } catch (std::bad_alloc& e) {
                Logger::getInstance().log("Error while allocating memory!!");
                return std::string();
        }
@@ -68,7 +68,7 @@ std::string make_message(const char *fmt, ...)
                        std::copy(p, p + old_size, np);
                        delete [] p;
                        p = np;
-               } catch (std::bad_alloc) {
+               } catch (std::bad_alloc& e) {
                        delete [] p;
                        Logger::getInstance().log("Error while allocating memory!!");
                        return std::string();

diff --git a/core/Tools/BookmarkItem.cpp b/core/Tools/BookmarkItem.cpp
index c801ad98af05febf436a8f8f395def74f558ebc3..441cc255342f073f3beb294a73807ed936b07a45 100644 (file)
--- a/core/Tools/BookmarkItem.cpp
+++ b/core/Tools/BookmarkItem.cpp
@@ -54,6 +54,8 @@ BookmarkItem::BookmarkItem(
 , m_title(title)
 , m_note(note)
 , m_directory(dir)
+, m_is_folder(false)
+, m_is_editable(true)
 {
 
 }

diff --git a/core/Tools/EflTools.cpp b/core/Tools/EflTools.cpp
index 2e3dad2e88acd18189c0dab0791da97f67c1960b..5f10dbfe7ad046ec7f7889dc44463870857e6205 100644 (file)
--- a/core/Tools/EflTools.cpp
+++ b/core/Tools/EflTools.cpp
@@ -42,7 +42,7 @@ std::unique_ptr<Blob> getBlobPNG(std::shared_ptr<BrowserImage> browserImage)
     }
     std::unique_ptr<Blob> image(new Blob(mem_buffer, length));
 
-    return std::move(image);
+    return image;
 }
 
 void* getBlobPNG(int width, int height, void* image_data, unsigned long long* length)

diff --git a/services/BookmarkFlowUI/BookmarkFlowUI.cpp b/services/BookmarkFlowUI/BookmarkFlowUI.cpp
index 138afeba546f57d8a35399826366b4089be05f0d..79179370022940db7b61f16b8312b6239157ac0b 100755 (executable)
--- a/services/BookmarkFlowUI/BookmarkFlowUI.cpp
+++ b/services/BookmarkFlowUI/BookmarkFlowUI.cpp
@@ -42,6 +42,8 @@ BookmarkFlowUI::BookmarkFlowUI()
     : m_parent(nullptr)
     , m_layout(nullptr)
     , m_title_area(nullptr)
+    , m_state(false)
+    , m_all_folder_id(0)
 #if PROFILE_MOBILE
     , m_contents_area(nullptr)
     , m_remove_button(nullptr)

diff --git a/services/BookmarkManagerUI/BookmarkManagerUI.cpp b/services/BookmarkManagerUI/BookmarkManagerUI.cpp
index 031cb80bbaf56235e9e8ae5d2e23df0f2e9ed1b9..f0b49aaffb3302b3deb68e3e0a54a90f6120a07b 100644 (file)
--- a/services/BookmarkManagerUI/BookmarkManagerUI.cpp
+++ b/services/BookmarkManagerUI/BookmarkManagerUI.cpp
@@ -52,6 +52,9 @@ BookmarkManagerUI::BookmarkManagerUI()
     , m_folder_all_item_class(nullptr)
     , m_folder_mobile_item_class(nullptr)
     , m_folder_custom_item_class(nullptr)
+    , m_all_folder_id(1)
+    , m_special_folder_id(1)
+
 {
     BROWSER_LOGD("[%s:%d] ", __PRETTY_FUNCTION__, __LINE__);
     m_edjFilePath = EDJE_DIR;

diff --git a/services/CertificateService/CertificateContents.cpp b/services/CertificateService/CertificateContents.cpp
index 4a33fb37473072f96547164b411a152216b1f662..bcbf84b06b5715c7933f74855b8d5db0ee24baa7 100644 (file)
--- a/services/CertificateService/CertificateContents.cpp
+++ b/services/CertificateService/CertificateContents.cpp
@@ -57,7 +57,10 @@ EXPORT_SERVICE(CertificateContents, "org.tizen.browser.certificateservice")
 
 CertificateContents::CertificateContents()
     : m_mainLayout(nullptr)
+    ,  m_genlist(nullptr)
     , m_parent(nullptr)
+    , m_certificate(nullptr)
+    , m_hostType(HOST_TYPE::HOST_ABSENT)
 {
     BROWSER_LOGD("[%s:%d] ", __PRETTY_FUNCTION__, __LINE__);
     m_edjFilePath = EDJE_DIR;

diff --git a/services/HistoryService/HistoryItem.cpp b/services/HistoryService/HistoryItem.cpp
index ec5cbad6757c4168c8b78dcd95e82eff64987d11..09e67fd35a0963049d7b29ac6ba424e3b1bcf0ff 100644 (file)
--- a/services/HistoryService/HistoryItem.cpp
+++ b/services/HistoryService/HistoryItem.cpp
@@ -23,6 +23,8 @@ namespace services
 {
 
 HistoryItem::HistoryItem(HistoryItem && other) noexcept
+    : m_primaryKey(0)
+    , m_visitCounter(0)
 {
     try {
         if (this != &other) {
@@ -41,8 +43,10 @@ HistoryItem::HistoryItem(int id,
     : m_primaryKey(id)
     , m_url(url)
     , m_title(title)
+    , m_visitDate()
     , m_lastVisit()
     , m_favIcon(favicon)
+    , m_visitCounter(0)
 {
     if (thumbnail)
         m_thumbnail = thumbnail;
@@ -54,8 +58,10 @@ HistoryItem::HistoryItem(int id, const std::string & url)
     : m_primaryKey(id)
     , m_url(url)
     , m_title()
+    , m_visitDate()
     , m_lastVisit()
     , m_favIcon(std::make_shared<tizen_browser::tools::BrowserImage>())
+    , m_visitCounter(0)
 {
 
 }

diff --git a/services/HistoryUI/HistoryDaysListManager/mob/HistoryDayItemMob.cpp b/services/HistoryUI/HistoryDaysListManager/mob/HistoryDayItemMob.cpp
index 32b3c7d9cef3374646b1a6799a282c3fb1739778..624f315036f1d040585fe522a840092ce59ac94f 100644 (file)
--- a/services/HistoryUI/HistoryDaysListManager/mob/HistoryDayItemMob.cpp
+++ b/services/HistoryUI/HistoryDaysListManager/mob/HistoryDayItemMob.cpp
@@ -31,6 +31,8 @@ HistoryDayItemMob::HistoryDayItemMob(HistoryDayItemDataPtr dayItemData)
     , m_boxMainVertical(nullptr)
     , m_layoutHeader(nullptr)
     , m_boxHeader(nullptr)
+    , m_layoutBoxWebsites(nullptr)
+    , m_boxWebsites(nullptr)
 {
     for (auto& websiteHistoryItemData : dayItemData->websiteHistoryItems) {
         auto websiteHistoryItem =

diff --git a/services/HistoryUI/HistoryDaysListManager/mob/WebsiteHistoryItem/WebsiteHistoryItemTitleMob.cpp b/services/HistoryUI/HistoryDaysListManager/mob/WebsiteHistoryItem/WebsiteHistoryItemTitleMob.cpp
index c1d552ecd6aaa68174310d65062242b8118792c5..ec1878acf0dfdbf48814dbc123b8cd6635d5f826 100644 (file)
--- a/services/HistoryUI/HistoryDaysListManager/mob/WebsiteHistoryItem/WebsiteHistoryItemTitleMob.cpp
+++ b/services/HistoryUI/HistoryDaysListManager/mob/WebsiteHistoryItem/WebsiteHistoryItemTitleMob.cpp
@@ -29,9 +29,11 @@ WebsiteHistoryItemTitleMob::WebsiteHistoryItemTitleMob(
         WebsiteHistoryItemDataPtr websiteHistoryItemData)
     : m_websiteHistoryItemData(websiteHistoryItemData)
     , m_buttonSelect(nullptr)
+    , m_buttonDelete(nullptr)
     , m_imageFavIcon(nullptr)
     , m_imageFavIconMask(nullptr)
     , m_layoutMain(nullptr)
+    , m_layerGesture(nullptr)
     , m_boxMain(nullptr)
     , m_layoutContent(nullptr)
     , m_layoutButtonDelete(nullptr)

diff --git a/services/HistoryUI/HistoryDaysListManager/tv/WebsiteHistoryItem/WebsiteHistoryItemTitleTv.cpp b/services/HistoryUI/HistoryDaysListManager/tv/WebsiteHistoryItem/WebsiteHistoryItemTitleTv.cpp
index a044538672eed700d546fed82bcbf2b9575a521d..2b41918fa37a1e9673cc46fc5b6385c364a7e271 100644 (file)
--- a/services/HistoryUI/HistoryDaysListManager/tv/WebsiteHistoryItem/WebsiteHistoryItemTitleTv.cpp
+++ b/services/HistoryUI/HistoryDaysListManager/tv/WebsiteHistoryItem/WebsiteHistoryItemTitleTv.cpp
@@ -31,9 +31,11 @@ WebsiteHistoryItemTitleTv::WebsiteHistoryItemTitleTv(
     : m_websiteHistoryItemData(websiteHistoryItemData)
     , m_buttonSelect(nullptr)
     , m_imageClear(nullptr)
+    , m_imageFavIcon(nullptr)
     , m_layoutMain(nullptr)
     , m_boxMainHorizontal(nullptr)
     , m_historyDeleteManager(historyDeleteManager)
+
 {
 }
 

diff --git a/services/MoreMenuUI/MoreMenuUI.cpp b/services/MoreMenuUI/MoreMenuUI.cpp
index d58ea1dc020535816c6cb9464f9cba72f70f0728..9c571f5275ccc4acd23fe84649d85ac43674c2bb 100755 (executable)
--- a/services/MoreMenuUI/MoreMenuUI.cpp
+++ b/services/MoreMenuUI/MoreMenuUI.cpp
@@ -50,7 +50,9 @@ MoreMenuUI::MoreMenuUI()
     , m_toastPopup(nullptr)
     , m_icon(nullptr)
     , m_bookmarkIcon(nullptr)
+    , m_bookmarkButton(nullptr)
     , m_item_class(nullptr)
+    , m_gengridSetup(true)
     , m_desktopMode(true)
 #if PROFILE_MOBILE
     , m_shouldShowFindOnPage(false)

diff --git a/services/QuickAccess/QuickAccess.cpp b/services/QuickAccess/QuickAccess.cpp
index 1823e2c5f2a5a541b2441ed055fb7cfed220717b..abaf87fa47352d1aaa11d43e216beda8a0474b7b 100644 (file)
--- a/services/QuickAccess/QuickAccess.cpp
+++ b/services/QuickAccess/QuickAccess.cpp
@@ -75,6 +75,9 @@ QuickAccess::QuickAccess()
     , m_currPage(QuickAccess::MOST_VISITED_PAGE)
     , m_bookmark_item_class(nullptr)
     , m_detailPopup(this)
+    , m_gengridSetup(false)
+    , m_desktopMode(true)
+
 #if PROFILE_MOBILE
     , m_index(nullptr)
     , m_verticalScroller(nullptr)

diff --git a/services/StorageService/Field.cpp b/services/StorageService/Field.cpp
index 912235c0b02e6b760db250d8ff751f959f4fe4f3..6aed04af7558dfd6c9b1270a570a3ab9d6be5cac 100644 (file)
--- a/services/StorageService/Field.cpp
+++ b/services/StorageService/Field.cpp
@@ -35,8 +35,10 @@ Field::Field()
     , sqlDouble(f.getDouble())
 {
 }
-/*private*/Field & Field::operator=(const Field &)
+/*private*/Field & Field::operator=(const Field & f)
 {
+    this->sqlInt = f.sqlInt;
+    this->sqlDouble = f.sqlDouble;
     return *this;
 }
 
@@ -55,12 +57,18 @@ Field::Field(double sqlDouble)
 }
 
 Field::Field(const std::string & sqlText)
+    : type(SQLITE3_TEXT)
+    , sqlInt(0)
+    , sqlDouble(0)
 {
     this->sqlText = sqlText;
     this->type = SQLITE3_TEXT;
 }
 
 Field::Field(std::shared_ptr<tizen_browser::tools::Blob> blob)
+    : type(SQLITE_BLOB)
+    , sqlInt(0)
+    , sqlDouble(0)
 {
     this->blob = blob;
     this->type = SQLITE_BLOB;

diff --git a/services/TabUI/TabUI.cpp b/services/TabUI/TabUI.cpp
index 1c9871a1836df5c8450c1b4055102548a68fa9a8..ceadc8780b78276d41353343dac4be5ed3a86c7a 100644 (file)
--- a/services/TabUI/TabUI.cpp
+++ b/services/TabUI/TabUI.cpp
@@ -41,10 +41,12 @@ TabUI::TabUI()
     : m_button_left(nullptr)
     , m_button_right(nullptr)
     , m_tab_layout(nullptr)
+    , m_gengrid_layout(nullptr)
     , m_gengrid(nullptr)
     , m_parent(nullptr)
     , m_itemToShow(nullptr)
     , m_timer(nullptr)
+    , editMode(false)
     , m_item_class(nullptr)
 {
     BROWSER_LOGD("[%s:%d] ", __PRETTY_FUNCTION__, __LINE__);

diff --git a/services/WebEngineService/WebEngineService.cpp b/services/WebEngineService/WebEngineService.cpp
index 1133884a54354f225112db841d79005502be4e59..0eeb84eac908fe01702dc4496d58ea0d00e6a6d7 100755 (executable)
--- a/services/WebEngineService/WebEngineService.cpp
+++ b/services/WebEngineService/WebEngineService.cpp
@@ -559,7 +559,7 @@ bool WebEngineService::switchToTab(tizen_browser::basic_webengine::TabId newTabI
     closeFindOnPage();
 #endif
     m_currentWebView = m_tabs[newTabId];
-    m_currentTabId = newTabId;
+    m_currentTabId == newTabId;
     m_mostRecentTab.erase(std::remove(m_mostRecentTab.begin(), m_mostRecentTab.end(), newTabId), m_mostRecentTab.end());
     m_mostRecentTab.push_back(newTabId);
 
@@ -601,7 +601,7 @@ bool WebEngineService::closeTab(TabId id) {
             m_currentWebView.reset();
     }
     if (m_tabs.size() == 0) {
-        m_currentTabId = TabId::NONE;
+        m_currentTabId == TabId::NONE;
     }
     else if (closingTabId == m_currentTabId && m_mostRecentTab.size()){
         res = switchToTab(m_mostRecentTab.back());

diff --git a/services/WebEngineService/WebView.cpp b/services/WebEngineService/WebView.cpp
index d642476ebc4436f6c5f6a549592686e42a1eb671..104e4f127ea39931a1971d77702a8f59406e2493 100755 (executable)
--- a/services/WebEngineService/WebView.cpp
+++ b/services/WebEngineService/WebView.cpp
@@ -85,7 +85,9 @@ WebView::WebView(Evas_Object * obj, TabId tabId, const std::string& title, bool
     , m_title(title)
     , m_redirectedURL("")
     , m_isLoading(false)
+    , m_loadProgress(0)
     , m_loadError(false)
+    , m_desktopMode(true)
     , m_suspended(false)
     , m_private(incognitoMode)
     , m_fullscreen(false)
@@ -874,7 +876,7 @@ void WebView::__newWindowRequest(void *data, Evas_Object *, void *out)
     /// \todo: Choose newly created tab.
     TabId id(TabId::NONE);
     TabId currentTabId = m_webEngine->currentTabId();
-    if (currentTabId != (id = m_webEngine->addTab(std::string(),
+    if (currentTabId != (id == m_webEngine->addTab(std::string(),
                                                                  &self->getTabId(),
                                                                  boost::none,
                                                                  std::string(),