Coverity issue fix, check invalid map value access 39/294339/2 accepted/tizen_8.0_unified accepted/tizen_9.0_unified accepted/tizen_unified accepted/tizen_unified_dev tizen tizen_8.0 tizen_9.0 accepted/tizen/8.0/unified/20231005.092555 accepted/tizen/9.0/unified/20241030.232849 accepted/tizen/unified/20230705.131030 accepted/tizen/unified/dev/20240620.003439 tizen_8.0_m2_release tizen_9.0_m2_release
authorKrishna Kant Jaju <krishna.jaju@samsung.com>
Fri, 16 Jun 2023 07:31:39 +0000 (13:01 +0530)
committerKrishna Kant Jaju <krishna.jaju@samsung.com>
Fri, 16 Jun 2023 08:00:48 +0000 (13:30 +0530)
Change-Id: I107965a242e30f8573855ffc5a1ed157f246689e
Signed-off-by: Krishna Kant Jaju <krishna.jaju@samsung.com>
common/uafv1tlvutil/src/TlvEncoderFactory.cpp
packaging/fido-asm.spec
server/auth_discovery/src/BtADProvider.cpp
server/auth_discovery/src/BtCon.cpp

index 98d39a531b93b270bf740220e02e8e297b389b23..5dcf46e4e08320858537b0d5e92100eb7d81f4bb 100755 (executable)
@@ -39,7 +39,11 @@ TlvEncoderFactory::getTlvEncoderById(int id)
        RET_IF_FAIL(__encoderTable != NULL, NULL);
 
        _INFO("");
-       return __encoderTable->find(id)->second;
+
+       if(__encoderTable->find(id) != __encoderTable->end())
+               return __encoderTable->find(id)->second;
+
+       return NULL;
 }
 
 TlvEncoderFactory::TlvEncoderFactory(void) {}
index 483a55185bb4fad44d3bde9acbb009df07da1076..8d0c50adbaa3c9203c3968e75a799b678a87378f 100755 (executable)
@@ -1,7 +1,7 @@
 
 Name:       fido-asm
 Summary:    Tizen FIDO Reference ASM
-Version:    0.0.1
+Version:    0.0.2
 Release:    1
 Group:      Social & Content/Other
 License:    Apache-2.0
index 8823086a17177b606af1e1a65300af029cd14cbc..a4831b075ad740d48d353ec657afe72aaa722ef7 100755 (executable)
@@ -214,7 +214,10 @@ BtAdProvider::getStubFromCache(int mappedIdx)
                return NULL;
        }
 
-       return __stubCache->find(mappedIdx)->second;
+       if(__stubCache->find(mappedIdx) != __stubCache->end())
+               return __stubCache->find(mappedIdx)->second;
+
+       return NULL;
 }
 
 BtAdProvider::~BtAdProvider(void)
index cc9940fcb2bf0bb16adcaa8dee475aeefc38eaf5..6eb59e314f55b378a83cd443d6d3c47f3aed3c0b 100755 (executable)
@@ -305,7 +305,9 @@ BtCon::sendReqSync(StringMap *reqData)
        RET_IF_FAIL(__sock->socket_fd != -1, NULL);
 
        __resp = NULL;
-       std::string reqTlvB64 = (reqData->find(RA_QUERY_KEY_REQUEST)->second);
+       std::string reqTlvB64 = "";
+       if(reqData->find(RA_QUERY_KEY_REQUEST) != reqData->end())
+               reqTlvB64 = reqData->find(RA_QUERY_KEY_REQUEST)->second;
        char *reqTlvB64Copy = strdup(reqTlvB64.c_str());
 
        __waitLoop = g_main_loop_new(NULL, FALSE);