Fix coverity issues

[Version] 0.2.3
[Issue Type] Coverity

Change-Id: I3462d33bfaf9dc818cd22a5fde085bf5548b822b
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>

diff --git a/packaging/audio-hal-bcm2837.spec b/packaging/audio-hal-bcm2837.spec
index 7f86e5667e3ac8ead64ba6d531c460cfb00a3741..c3f527aa4106ed8be5ee0093a687ad2bac491210 100644 (file)
--- a/packaging/audio-hal-bcm2837.spec
+++ b/packaging/audio-hal-bcm2837.spec
@@ -1,6 +1,6 @@
 Name:       audio-hal-bcm2837
 Summary:    TIZEN Audio HAL for BCM2837
-Version:    0.2.2
+Version:    0.2.3
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0

diff --git a/tizen-audio-file.c b/tizen-audio-file.c
index d32a174ac9b9720172311a1553ff2e27109e67cc..78adf0187a3b5b630577fbd804be1fe353917be6 100644 (file)
--- a/tizen-audio-file.c
+++ b/tizen-audio-file.c
@@ -133,14 +133,21 @@ static audio_return_e audio_file_avail(void *audio_handle, void *handle, uint32_
         return AUDIO_ERR_INTERNAL;
     }
 
-    fseek(h->fp, 0L, SEEK_END);
+    if (fseek(h->fp, 0L, SEEK_END) < 0) {
+        AUDIO_LOG_ERROR("failed to seek 0. errno(%d)", errno);
+        return AUDIO_ERR_INTERNAL;
+    }
+
     end = ftell(h->fp);
     if (end < 0) {
         AUDIO_LOG_ERROR("failed to get ftell(%d)", errno);
         return AUDIO_ERR_INTERNAL;
     }
 
-    fseek(h->fp, cur, SEEK_SET);
+    if (fseek(h->fp, cur, SEEK_SET) < 0) {
+        AUDIO_LOG_ERROR("failed to seek current. cur(%ld), errno(%d)", cur, errno);
+        return AUDIO_ERR_INTERNAL;
+    }
 
     *avail = (uint32_t)MAX(end - cur, 0);
 

diff --git a/tizen-audio-impl-ctrl.c b/tizen-audio-impl-ctrl.c
index 49f6373511847d468e95dcd462fb78b8f687fe82..4e571f64df581cc4498d54112bcf6ad4aaaac79a 100644 (file)
--- a/tizen-audio-impl-ctrl.c
+++ b/tizen-audio-impl-ctrl.c
@@ -115,9 +115,9 @@ audio_return_e _mixer_control_get_value(audio_hal_s *ah, const char *ctl_name, i
     snd_ctl_elem_value_set_id(control, id);
 
     if (snd_ctl_elem_read(handle, control) < 0) {
-        AUDIO_LOG_ERROR("snd_ctl_elem_read failed \n");
+        AUDIO_LOG_ERROR("snd_ctl_elem_read failed");
         goto close;
-}
+    }
 
     switch (type) {
     case SND_CTL_ELEM_TYPE_BOOLEAN:
@@ -194,7 +194,10 @@ audio_return_e _mixer_control_set_value(audio_hal_s *ah, const char *ctl_name, i
 
     snd_ctl_elem_value_set_id(control, id);
 
-    snd_ctl_elem_read(handle, control);
+    if (snd_ctl_elem_read(handle, control) < 0) {
+        AUDIO_LOG_ERROR("snd_ctl_elem_read failed");
+        goto close;
+    }
 
     switch (type) {
     case SND_CTL_ELEM_TYPE_BOOLEAN: