test: Fix to initialize the buffer 10/295310/1 accepted/tizen_8.0_unified accepted/tizen_unified_riscv tizen_8.0 accepted/tizen/8.0/unified/20231005.092649 accepted/tizen/unified/20230706.152153 accepted/tizen/unified/dev/20230726.115758 accepted/tizen/unified/riscv/20231211.234013 tizen_8.0_m2_release
authorSangYoun Kwak <sy.kwak@samsung.com>
Wed, 5 Jul 2023 04:51:38 +0000 (13:51 +0900)
committerSangYoun Kwak <sy.kwak@samsung.com>
Wed, 5 Jul 2023 04:51:38 +0000 (13:51 +0900)
In src/test/test_diagnostics_data_write.c, test functions are using char
array(256-byte length) as a buffer but they did not initialized.

Because of this uninitialized buffers, errors were raised by the gcc-13
compiler like below:
error: 'buf' may be used uninitialized
To fix this issue, buffers were initialized when they are declared.

Change-Id: If69983ddce58be07b3269741acd4ba9fba587936
Signed-off-by: SangYoun Kwak <sy.kwak@samsung.com>
src/test/test_diagnostics_data_write.c

index 569388128c4dae15c927afa43f77c21fad0c9eaa..446f9fc211da05360a1343d9327dd879e39cc4f6 100644 (file)
@@ -21,7 +21,7 @@
 static void test_diagnostics_data_write_n1(void **state)
 {
        (void) state;
-       char buf[256];
+       char buf[256] = { 0 };
        size_t count = sizeof(buf);
        size_t bytes_written = 0;
 
@@ -32,7 +32,7 @@ static void test_diagnostics_data_write_n2(void **state)
 {
        (void) state;
        struct _diagnostics_data_s data;
-       char buf[256];
+       char buf[256] = { 0 };
        size_t count = sizeof(buf);
        size_t bytes_written = 0;
 
@@ -43,7 +43,7 @@ static void test_diagnostics_data_write_n3(void **state)
 {
        (void) state;
        struct _diagnostics_data_s data;
-       char buf[256];
+       char buf[256] = { 0 };
        size_t count = sizeof(buf);
 
        assert_int_equal(diagnostics_data_write(&data, buf, count, NULL), DIAGNOSTICS_ERROR_INVALID_PARAMETER);
@@ -54,7 +54,7 @@ static void test_diagnostics_data_write_n4(void **state)
        (void) state;
        struct _diagnostics_data_s data;
        data.fd = 0;
-       char buf[256];
+       char buf[256] = { 0 };
        size_t count = sizeof(buf);
        size_t bytes_written = 0;
 
@@ -69,7 +69,7 @@ static void test_diagnostics_data_write_n5(void **state)
        (void) state;
        struct _diagnostics_data_s data;
        data.fd = 0;
-       char buf[256];
+       char buf[256] = { 0 };
        size_t count = sizeof(buf);
        size_t bytes_written = 0;
 
@@ -84,7 +84,7 @@ static void test_diagnostics_data_write_p1(void **state)
        (void) state;
        struct _diagnostics_data_s data;
        data.fd = 0;
-       char buf[256];
+       char buf[256] = { 0 };
        size_t count = sizeof(buf);
        size_t bytes_written = 0;