Checked return value 49/259649/1 accepted/tizen_6.5_unified accepted/tizen_7.0_unified accepted/tizen_7.0_unified_hotfix accepted/tizen_8.0_unified tizen_6.5 tizen_7.0 tizen_7.0_hotfix tizen_8.0 accepted/tizen/6.5/unified/20211029.015617 accepted/tizen/7.0/unified/20221110.061537 accepted/tizen/7.0/unified/hotfix/20221116.111605 accepted/tizen/8.0/unified/20231005.095716 accepted/tizen/unified/20210611.144943 accepted/tizen/unified/riscv/20231226.211115 submit/tizen/20210611.044056 submit/tizen_6.5/20211028.163901 tizen_6.5.m2_release tizen_7.0_m2_release tizen_8.0_m2_release
authordyamy-lee <dyamy.lee@samsung.com>
Thu, 10 Jun 2021 10:39:17 +0000 (19:39 +0900)
committerdyamy-lee <dyamy.lee@samsung.com>
Thu, 10 Jun 2021 10:39:17 +0000 (19:39 +0900)
Changed coverity rule checked the function which has return value.
So, following this rule, add checking return value of tbm_surface fuction.

Change-Id: Ic717804a8bdc6a2b97b0eba37e1c2f1978c5f163

base/base_gui_direct.c

index 676ad35f46c305a6ebd2665ebfbf0d38d6067040..2b497d1675039c6381b8c5230c3f66298b7a9e7e 100644 (file)
@@ -450,12 +450,18 @@ static void __init_screen(FbInfo *fbi)
        /* create tbm_surface for original image */
        tbm_surface_h tbm_surface_ori = NULL;
        tbm_surface_info_s surface_info_ori;
+       tbm_surface_error_e result = TBM_SURFACE_ERROR_NONE;
+
        tbm_surface_ori = tbm_surface_create(img_buf_width, img_buf_height, TBM_FORMAT_ARGB8888);  // rotated width, height
        if(!tbm_surface_ori){
                LOG("failed to tbm_surface_create\n");
+               return;
+       }
+       result = tbm_surface_map(tbm_surface_ori, TBM_SURF_OPTION_READ | TBM_SURF_OPTION_WRITE, &surface_info_ori);
+       if(result != TBM_SURFACE_ERROR_NONE) {
+               LOG("tbm_surface_map failed: %d\n", result);
+               return;
        }
-       tbm_surface_map(tbm_surface_ori, TBM_SURF_OPTION_READ | TBM_SURF_OPTION_WRITE, &surface_info_ori);
-
 
        _gr_direct_clear_screen_init(&surface_info_ori, COLOR_BLACK);
 
@@ -543,12 +549,18 @@ void fota_gr_direct_progress(int * saved_percent, int * percent_to_draw)
                /* create tbm_surface for original image */
                tbm_surface_h tbm_surface_ori = NULL;
                tbm_surface_info_s surface_info_ori;
+               tbm_surface_error_e result = TBM_SURFACE_ERROR_NONE;
 
                tbm_surface_ori = tbm_surface_create(img_buf_width, img_buf_height, TBM_FORMAT_ARGB8888);  // rotated width, height
                if(!tbm_surface_ori){
                        LOG("failed to tbm_surface_create\n");
+                       return;
+               }
+               result = tbm_surface_map(tbm_surface_ori, TBM_SURF_OPTION_READ | TBM_SURF_OPTION_WRITE, &surface_info_ori);
+               if(result != TBM_SURFACE_ERROR_NONE) {
+                       LOG("tbm_surface_map failed: %d\n", result);
+                       return;
                }
-               tbm_surface_map(tbm_surface_ori, TBM_SURF_OPTION_READ | TBM_SURF_OPTION_WRITE, &surface_info_ori);
                // need to keep previous image
                _copy_buffers_by_rotate(s_fbi.buf[0], s_fbi.w, s_fbi.h, s_fbi.w * RGB32_PITCH,
                                surface_info_ori.planes[0].ptr, surface_info_ori.width, surface_info_ori.height, surface_info_ori.planes[0].stride,