Fix noise when unmuting radio volume

[Version] 0.1.31
[Issue Type] Improvement

Change-Id: I8b8063986c3e17d812afcf654c099967ec70919a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>

diff --git a/packaging/audio-hal-sc7727.spec b/packaging/audio-hal-sc7727.spec
index ffa9242..a575d74 100644 (file)
--- a/packaging/audio-hal-sc7727.spec
+++ b/packaging/audio-hal-sc7727.spec
@@ -1,6 +1,6 @@
 Name:       audio-hal-sc7727
 Summary:    TIZEN Audio HAL for SC7727
-Version:    0.1.30
+Version:    0.1.31
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0

diff --git a/tizen-audio-volume.c b/tizen-audio-volume.c
index 97e445c..8dd03f1 100644 (file)
--- a/tizen-audio-volume.c
+++ b/tizen-audio-volume.c
@@ -360,18 +360,6 @@ static audio_return_t _audio_volume_set_ratio_radio(audio_hal_t *ah, double rati
         goto set_volume;
     }
 
-    /* Unmute if muted */
-    if ((audio_ret = _mixer_control_get_value(ah, MIXER_FMRADIO_MUTE, &mute))) {
-        AUDIO_LOG_ERROR("[mute get] get mixer(%s) failed", MIXER_FMRADIO_MUTE);
-        return audio_ret;
-    }
-    if (mute == FMRADIO_MUTE_ON) {
-        if ((audio_ret = _mixer_control_set_value(ah, MIXER_FMRADIO_MUTE, FMRADIO_MUTE_OFF))) {
-            AUDIO_LOG_ERROR("[mute off] set mixer(%s) failed", MIXER_FMRADIO_MUTE);
-            return audio_ret;
-        }
-    }
-
     max_value = ah->volume.radio_volume_value_table[ah->volume.radio_volume_num_of_levels - 1];
     min_value = ah->volume.radio_volume_value_table[0];
     new_value = (int) (ratio * (max_value - min_value) + min_value);
@@ -399,6 +387,21 @@ set_volume:
         }
     }
 
+    if (ratio == 0)
+        return audio_ret;
+
+    /* Unmute if muted */
+    if ((audio_ret = _mixer_control_get_value(ah, MIXER_FMRADIO_MUTE, &mute))) {
+        AUDIO_LOG_ERROR("[mute get] get mixer(%s) failed", MIXER_FMRADIO_MUTE);
+        return audio_ret;
+    }
+    if (mute == FMRADIO_MUTE_ON) {
+        if ((audio_ret = _mixer_control_set_value(ah, MIXER_FMRADIO_MUTE, FMRADIO_MUTE_OFF))) {
+            AUDIO_LOG_ERROR("[mute off] set mixer(%s) failed", MIXER_FMRADIO_MUTE);
+            return audio_ret;
+        }
+    }
+
     return audio_ret;
 }