[0.1.17] fix svace issue 99/134099/1
authorEunhae Choi <eunhae1.choi@samsung.com>
Wed, 14 Jun 2017 12:47:56 +0000 (21:47 +0900)
committerEunhae Choi <eunhae1.choi@samsung.com>
Wed, 14 Jun 2017 12:47:56 +0000 (21:47 +0900)
Change-Id: Ie1572cedafa46e69b129467f57b58e790d36357a

packaging/capi-media-streamer.spec
src/media_streamer_node.c

index 9e8832c..b72d961 100644 (file)
@@ -1,6 +1,6 @@
 Name:       capi-media-streamer
 Summary:    A Media Streamer API
-Version:    0.1.16
+Version:    0.1.17
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index 33afa5b..8c57112 100644 (file)
@@ -149,8 +149,10 @@ static int __ms_rtp_node_set_property(media_streamer_node_s *ms_node, param_s *p
        int ret = MEDIA_STREAMER_ERROR_NONE;
 
        GValue *val = (GValue *)g_object_get_data(G_OBJECT(ms_node->gst_element), param->param_name);
-       if (!val)
-               ret = MEDIA_STREAMER_ERROR_INVALID_PARAMETER;
+       if (!val) {
+               ms_error("fail to get [%s] val from [%s]", param->param_name, GST_ELEMENT_NAME(ms_node->gst_element));
+               return MEDIA_STREAMER_ERROR_INVALID_PARAMETER;
+       }
 
        if (!strcmp(param->param_name, MEDIA_STREAMER_PARAM_VIDEO_IN_PORT) ||
                !strcmp(param->param_name, MEDIA_STREAMER_PARAM_AUDIO_IN_PORT) ||
@@ -170,10 +172,12 @@ static int __ms_rtp_node_set_property(media_streamer_node_s *ms_node, param_s *p
                        g_value_unset(val);
                        g_value_init(val, GST_TYPE_CAPS);
                        gst_value_set_caps(val, caps);
-               } else
+               } else {
                        ret = MEDIA_STREAMER_ERROR_INVALID_PARAMETER;
-       } else
+               }
+       } else {
                ret = MEDIA_STREAMER_ERROR_INVALID_PARAMETER;
+       }
 
        return ret;
 }
@@ -221,15 +225,18 @@ static int __ms_adaptive_src_node_set_property(media_streamer_node_s *ms_node, p
        int ret = MEDIA_STREAMER_ERROR_NONE;
 
        GValue *val = (GValue *)g_object_get_data(G_OBJECT(ms_node->gst_element), param->param_name);
-       if (!val)
-               ret = MEDIA_STREAMER_ERROR_INVALID_PARAMETER;
+       if (!val) {
+               ms_error("fail to get [%s] val from [%s]", param->param_name, GST_ELEMENT_NAME(ms_node->gst_element));
+               return MEDIA_STREAMER_ERROR_INVALID_PARAMETER;
+       }
 
        if (!strcmp(param->param_name, MEDIA_STREAMER_PARAM_URI)) {
                g_value_unset(val);
                g_value_init(val, G_TYPE_STRING);
                g_value_set_string(val, param_value);
-       } else
+       } else {
                ret = MEDIA_STREAMER_ERROR_INVALID_PARAMETER;
+       }
 
        return ret;
 }