elm: Fix potential null point dereferences.

   Summary:
   If every assigning logics to enginelist is not performed some how,
   system will crash because the first parameter of strcmp is null.

   Test Plan: N/A

   Reviewers: Hermet

   Reviewed By: Hermet

   Subscribers: cedric, Hermet, raster, jpeg

   Differential Revision: https://phab.enlightenment.org/D4149

Change-Id: I98a3d95540758740a262b2371994b51bfd0075da

diff --git a/src/lib/elm_win.c b/src/lib/elm_win.c
index ae75d89..3c8d993 100644 (file)
--- a/src/lib/elm_win.c
+++ b/src/lib/elm_win.c
@@ -4039,10 +4039,9 @@ _elm_win_finalize_internal(Eo *obj, Elm_Win_Data *sd, const char *name, Elm_Win_
 #endif
                }
           }
-        enginelist[p++] = NULL;
-        for (i = 0; i < 30; i++)
+
+        for (i = 0; i < p; i++)
           {
-             if ((i > 0) && (!enginelist[i])) break;
              if (!strcmp(enginelist[i], ELM_SOFTWARE_X11))
                tmp_sd.ee = ecore_evas_software_x11_new(NULL, 0, 0, 0, 1, 1);
              else if (!strcmp(enginelist[i], ELM_OPENGL_X11))