pass: thermal: Fix to return proper value for dbus signal handler 97/281897/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/20221110.063429 accepted/tizen/7.0/unified/hotfix/20221116.105751 accepted/tizen/unified/20220927.132311 tizen_7.0_m2_release
authorSeung-Woo Kim <sw0312.kim@samsung.com>
Fri, 23 Sep 2022 02:09:52 +0000 (11:09 +0900)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Fri, 23 Sep 2022 04:47:48 +0000 (13:47 +0900)
From the dbus-stub generated code, signal handler should return
TRUE if it handles invocation. Even ret value is error, fix to
return TRUE after handling invocation.

Below is dbus-stub comment about signal handler:
  If a signal handler returns %TRUE, it means the signal handler
  will handle the invocation and no other signal handlers will
  run. If no signal handler handles the invocation, the
  %G_DBUS_ERROR_UNKNOWN_METHOD error is returned.
  Returns: %G_DBUS_METHOD_INVOCATION_HANDLED or %TRUE if the
   invocation was handled,
   %G_DBUS_METHOD_INVOCATION_UNHANDLED or %FALSE to let
   other signal handlers run.

NOTE: GLIB related asan heap-buffer-overflow issue is from the
wrong return.

Change-Id: I4db508aafba556406dce63bb0309d55c9f8a4696
Suggested-by: Sangjung Woo <sangjung.woo@samsung.com>
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
src/thermal/thermal.c

index 60440ab..8d8cb85 100644 (file)
@@ -216,7 +216,7 @@ static gboolean dbus_cb_thermal_start(SystemThermal *obj,
 
        _E("failed to initialize Thermal Monitor of the daemon "
                        "in dbus callback for a start message\n");
-       return FALSE;
+       return TRUE;
 }
 
 /**