Fix issue detected by static analysis tool

Fix memory leak issues in some conditions

Change-Id: I7053d6c0e054b776c71135911fde139f9c40f974
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>

diff --git a/src/autofill-daemon.c b/src/autofill-daemon.c
index 8806be5..4235bb0 100644 (file)
--- a/src/autofill-daemon.c
+++ b/src/autofill-daemon.c
@@ -485,6 +485,15 @@ static int __commit_cb(rpc_port_stub_AutofillAppPort_context_h context, int cont
 
     rpc_port_proxy_autofill_svc_save_view_info_set_items(svi, svc_save_items);
 
+    if (g_autofill_service_connected && svc_rpc_h) {
+        rpc_port_proxy_AutofillSvcPort_invoke_commit(svc_rpc_h, context_id, svi);
+        rpc_port_proxy_autofill_svc_save_view_info_destroy(svi);
+    }
+    else {
+        add_request_item(COMMIT, context_id, svi);
+    }
+
+end:
     if (view_id) {
         free(view_id);
         view_id = NULL;
@@ -495,15 +504,6 @@ static int __commit_cb(rpc_port_stub_AutofillAppPort_context_h context, int cont
         view_title = NULL;
     }
 
-    if (g_autofill_service_connected && svc_rpc_h) {
-        rpc_port_proxy_AutofillSvcPort_invoke_commit(svc_rpc_h, context_id, svi);
-        rpc_port_proxy_autofill_svc_save_view_info_destroy(svi);
-    }
-    else {
-        add_request_item(COMMIT, context_id, svi);
-    }
-
-end:
     if (svc_save_items) {
         rpc_port_proxy_list_autofill_svc_save_item_destroy(svc_save_items);
     }