[Archive][Exif] Added missing error checking 92/190492/1
authorPiotr Kosko <p.kosko@samsung.com>
Tue, 2 Oct 2018 11:25:19 +0000 (13:25 +0200)
committerPiotr Kosko <p.kosko@samsung.com>
Tue, 2 Oct 2018 12:07:52 +0000 (14:07 +0200)
[Verification] Code compiles without errors.

Change-Id: I588a1d08f4dea4a19038653b2889a1daa5b45673
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
src/archive/zip_add_request.cc
src/exif/jpeg_file.cc
src/humanactivitymonitor/humanactivitymonitor_manager.cc

index d8cb38d9c9a87e66cd55911a9abab2a1dcfbb1a0..d6e862f358276eee399defe1045164ca38b297c9 100644 (file)
@@ -360,7 +360,11 @@ PlatformResult ZipAddRequest::addToZipArchive(filesystem::NodePtr src_file_node)
     // Get file length
     fseek(m_input_file, 0, SEEK_END);
     const size_t in_file_size = ftell(m_input_file);
-    fseek(m_input_file, 0, SEEK_SET);
+    int res = fseek(m_input_file, 0, SEEK_SET);
+    if (0 != res) {
+      return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Reading input file failed",
+                                ("fseek failed with error! [%d]", res));
+    }
     LoggerD("Source file: [%s] size: %d - %s", src_file_path.c_str(), in_file_size,
             bytesToReadableString(in_file_size).c_str());
 
index aefd179bf728ed0061314a42e7cfdce90df34a7e..39bf00c7ca1a723870bfb22e58371a192e15ef90 100644 (file)
@@ -148,7 +148,11 @@ PlatformResult JpegFile::load(const std::string& path) {
                               ("Couldn't open Jpeg file: [%s]", path.c_str()));
   }
 
-  fseek(m_in_file, 0, SEEK_END);
+  int res = fseek(m_in_file, 0, SEEK_END);
+  if (0 != res) {
+    return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Reading JPEG file failed",
+                              ("fseek failed with error! [%d]", res));
+  }
 
   long ftell_val = ftell(m_in_file);
   if (0 > ftell_val) {
index 1dc5779d59e101a01aa4b0c735cc668a079386b4..13f3a0c7fae783652e78519789cd3c60b57ee990 100644 (file)
@@ -1523,8 +1523,8 @@ HumanActivityMonitorManager::HumanActivityMonitorManager()
     return ConvertRecordedTime(data, obj);
   };
 
-  monitors_.insert(std::make_pair(kActivityTypePedometer,
-                                  std::make_shared<Monitor::PedometerMonitor>()));
+  monitors_.insert(
+      std::make_pair(kActivityTypePedometer, std::make_shared<Monitor::PedometerMonitor>()));
   monitors_.insert(std::make_pair(kActivityTypeWristUp,
                                   std::make_shared<Monitor::GestureMonitor>(kActivityTypeWristUp)));
   monitors_.insert(std::make_pair(