Fix coverity issues 92/186192/3 accepted/tizen/unified/20180809.074727 submit/tizen/20180808.054211
authorSeungbae Shin <seungbae.shin@samsung.com>
Wed, 8 Aug 2018 03:51:29 +0000 (12:51 +0900)
committerSeungbae Shin <seungbae.shin@samsung.com>
Wed, 8 Aug 2018 05:29:19 +0000 (14:29 +0900)
[Version] 0.5.9
[Issue Type] Coverity

Change-Id: I1b3656a8f50b1635c5f99427b0ca598fa95c4a81

packaging/capi-media-sound-manager.spec
src/sound_manager.c

index 79e0dc50c92339f41d61d3905d8e085742ca337e..6fbd2f7dee873a75dcefed385983c6d6ba5e4af6 100644 (file)
@@ -1,6 +1,6 @@
 Name:       capi-media-sound-manager
 Summary:    Sound Manager library
-Version:    0.5.8
+Version:    0.5.9
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index e178d5bbadccb3399216fa20ed72dabf73338fb7..6c74e77f69178d7549f7444ecba6c1e9554d1b11 100644 (file)
@@ -623,11 +623,10 @@ int sound_manager_get_current_playback_focus(sound_stream_focus_change_reason_e
                        LOGI("                                : reason[%d], flags[0x%x], extra_info[%s]", *acquired_by, option, extra_info_str);
                        *flags = option;
                        if (extra_info)
-                               *extra_info = extra_info_str;
-                       else
-                               SM_SAFE_FREE(extra_info_str);
+                               *extra_info = strdup(extra_info_str);
                }
                SM_SAFE_FREE(stream_type_str);
+               SM_SAFE_FREE(extra_info_str);
        }
 
        return _convert_sound_manager_error_code(__func__, ret);
@@ -662,11 +661,10 @@ int sound_manager_get_current_recording_focus(sound_stream_focus_change_reason_e
                        LOGI("                                 : reason[%d], flags[0x%x], extra_info[%s]", *acquired_by, option, extra_info_str);
                        *flags = option;
                        if (extra_info)
-                               *extra_info = extra_info_str;
-                       else
-                               SM_SAFE_FREE(extra_info_str);
+                               *extra_info = strdup(extra_info_str);
                }
                SM_SAFE_FREE(stream_type_str);
+               SM_SAFE_FREE(extra_info_str);
        }
 
        return _convert_sound_manager_error_code(__func__, ret);