[0.3.135] Fix coverity issue (Resource Leak) 91/244191/2 accepted/tizen/unified/20200916.212649 submit/tizen/20200916.082856
authorGilbok Lee <gilbok.lee@samsung.com>
Wed, 16 Sep 2020 01:37:00 +0000 (10:37 +0900)
committerGilbok Lee <gilbok.lee@samsung.com>
Wed, 16 Sep 2020 02:51:45 +0000 (11:51 +0900)
Change-Id: Ia37ba85714fc8dd4744f5bc10ba6ff44437fc3db

packaging/capi-media-player.spec
test/player_audio_test.c
test/player_test.c

index 1fb0ef0..204afdf 100644 (file)
@@ -1,6 +1,6 @@
 Name:       capi-media-player
 Summary:    A Media Player API
-Version:    0.3.134
+Version:    0.3.135
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index 434a039..374cd98 100644 (file)
@@ -91,6 +91,7 @@ static tizen_profile_t _get_tizen_profile()
 #define TIZEN_TV  ((_get_tizen_profile()) == TIZEN_PROFILE_TV)
 
 static gboolean g_memory_playback = FALSE;
+GMappedFile *g_file = NULL;
 static char g_uri[MAX_STRING_LEN];
 static FILE *g_pcm_fd;
 
@@ -279,13 +280,12 @@ static void input_filename(char *filename)
 /* use this API instead of player_set_uri */
 static void player_set_memory_buffer_test()
 {
-       GMappedFile *file;
        gsize file_size;
        guint8 *g_media_mem = NULL;
 
-       file = g_mapped_file_new(g_uri, FALSE, NULL);
-       file_size = g_mapped_file_get_length(file);
-       g_media_mem = (guint8 *)g_mapped_file_get_contents(file);
+       g_file = g_mapped_file_new(g_uri, FALSE, NULL);
+       file_size = g_mapped_file_get_length(g_file);
+       g_media_mem = (guint8 *)g_mapped_file_get_contents(g_file);
 
        int ret = player_set_memory_buffer(g_player[0], (void *)g_media_mem, file_size);
        g_print("player_set_memory_buffer ret : %d\n", ret);
@@ -516,6 +516,11 @@ static void _player_destroy()
                fclose(fp_out2);
 #endif
 
+       if (g_file) {
+               g_mapped_file_unref(g_file);
+               g_file = NULL;
+       }
+
 }
 
 static void _player_play()
index dd61cdd..8efcd93 100644 (file)
@@ -108,6 +108,7 @@ static tizen_profile_e _get_tizen_profile()
 #define TIZEN_TV  ((_get_tizen_profile()) == TIZEN_PROFILE_TV)
 
 static gboolean g_memory_playback = FALSE;
+GMappedFile *g_file = NULL;
 static char g_uri[MAX_STRING_LEN];
 static char g_subtitle_uri[MAX_STRING_LEN];
 static FILE *g_pcm_fd;
@@ -763,13 +764,12 @@ static void input_filename(char *filename)
 /* use this API instead of player_set_uri */
 static void player_set_memory_buffer_test()
 {
-       GMappedFile *file;
        gsize file_size;
        guint8 *g_media_mem = NULL;
 
-       file = g_mapped_file_new(g_uri, FALSE, NULL);
-       file_size = g_mapped_file_get_length(file);
-       g_media_mem = (guint8 *)g_mapped_file_get_contents(file);
+       g_file = g_mapped_file_new(g_uri, FALSE, NULL);
+       file_size = g_mapped_file_get_length(g_file);
+       g_media_mem = (guint8 *)g_mapped_file_get_contents(g_file);
 
        int ret = player_set_memory_buffer(g_player[0], (void *)g_media_mem, file_size);
        g_print("player_set_memory_buffer ret : %d\n", ret);
@@ -1201,6 +1201,11 @@ static void _player_destroy()
                fclose(fp_out2);
 #endif
 
+       if (g_file) {
+               g_mapped_file_unref(g_file);
+               g_file = NULL;
+       }
+
 }
 
 static void _player_play()