fix coverity issue Unchecked return value 88/233688/1
authorwansu.yoo <wansu.yoo@samsung.com>
Mon, 17 Feb 2020 04:21:27 +0000 (13:21 +0900)
committerMukunth A <a.mukunth@samsung.com>
Mon, 18 May 2020 08:15:46 +0000 (08:15 +0000)
Change-Id: I6fe43e94d3a5d87fe3aebd4708744fe4193e349f
Signed-off-by: wansu.yoo <wansu.yoo@samsung.com>
(cherry picked from commit 83629e88851e5d6cd1e0b48e76d5b4c901ec4a93)

CMain/src/orchestration_dbus_server.c

index add4635..ec11fe0 100644 (file)
@@ -320,10 +320,13 @@ static int _request_service(GVariant *parameters, int origin_client_pid)
     DEBUG("\t client_pid = %d\n", client_pid);
 
     for (int i = 0; i < count; i++) {
-        g_variant_iter_loop (iter, "(ss)", &service_info[i].ExecutionType, &service_info[i].ExeCmd);
-
-        DEBUG("\t service_info[%d].ExecutionType = %s\n", i, service_info[i].ExecutionType);
-        DEBUG("\t service_info[%d].ExeCmd = %s\n", i, service_info[i].ExeCmd);
+        if (g_variant_iter_loop (iter, "(ss)", &service_info[i].ExecutionType, &service_info[i].ExeCmd)) {
+            DEBUG("\t service_info[%d].ExecutionType = %s\n", i, service_info[i].ExecutionType);
+            DEBUG("\t service_info[%d].ExeCmd = %s\n", i, service_info[i].ExeCmd);
+        } else {
+            DEBUG("\t no more items to iterate!!!\n");
+            break;
+        }
     }
     g_variant_iter_free (iter);