keyrouter: simplify chained if-statements with AND operator 85/283185/1
authorduna.oh <duna.oh@samsung.com>
Tue, 18 Oct 2022 01:10:24 +0000 (10:10 +0900)
committerTizen Window System <tizen.windowsystem@gmail.com>
Thu, 20 Oct 2022 02:41:56 +0000 (11:41 +0900)
Change-Id: I4117fcb3fae1284906b30ce6d657e47b7efc3e22

src/bin/e_keyrouter_list.c

index 5830987..de87c62 100644 (file)
@@ -223,21 +223,19 @@ e_keyrouter_find_and_remove_client_from_list(struct wl_resource *surface, struct
      {
         if (!key_node_data) continue;
 
-        if (surface)
+        if (surface && (surface == key_node_data->surface))
           {
-             if (surface == key_node_data->surface)
+             if (mode == TIZEN_KEYROUTER_MODE_PRESSED)
+               {
+                  key_node_data->status = E_KRT_CSTAT_UNGRAB;
+               }
+             else
                {
-                  if (mode == TIZEN_KEYROUTER_MODE_PRESSED)
-                    {
-                       key_node_data->status = E_KRT_CSTAT_UNGRAB;
-                    }
-                  else
-                    {
-                       *list = eina_list_remove_list(*list, l);
-                       E_FREE(key_node_data);
-                    }
-                  KLDBG("Remove a %s Mode Grabbed key(%d) by surface(%p)", e_keyrouter_mode_to_string(mode), key, surface);
+                  *list = eina_list_remove_list(*list, l);
+                  E_FREE(key_node_data);
                }
+             KLDBG("Remove a %s Mode grabbed key(%d) by surface(%p)", e_keyrouter_mode_to_string(mode), key, surface);
+             return;
           }
         else if ((wc == key_node_data->wc))
           {
@@ -272,14 +270,11 @@ e_keyrouter_remove_client_from_list(struct wl_resource *surface, struct wl_clien
           {
              if (!key_node_data) continue;
 
-             if (surface)
+             if (surface && (surface == key_node_data->surface))
                {
-                  if (surface == key_node_data->surface)
-                    {
-                       krt->HardKeys[i].excl_ptr = eina_list_remove_list(krt->HardKeys[i].excl_ptr, l);
-                       E_FREE(key_node_data);
-                       KLDBG("Remove a Exclusive Mode Grabbed key(%d) by wl_surface(%p)", i, surface);
-                    }
+                  krt->HardKeys[i].excl_ptr = eina_list_remove_list(krt->HardKeys[i].excl_ptr, l);
+                  E_FREE(key_node_data);
+                  KLDBG("Remove a Exclusive Mode Grabbed key(%d) by wl_surface(%p)", i, surface);
                }
              else if ((wc == key_node_data->wc))
                {
@@ -292,14 +287,11 @@ e_keyrouter_remove_client_from_list(struct wl_resource *surface, struct wl_clien
           {
              if (!key_node_data) continue;
 
-             if (surface)
+             if (surface && (surface == key_node_data->surface))
                {
-                  if (surface == key_node_data->surface)
-                    {
-                       krt->HardKeys[i].or_excl_ptr = eina_list_remove_list(krt->HardKeys[i].or_excl_ptr, l);
-                       E_FREE(key_node_data);
-                       KLDBG("Remove a Overridable_Exclusive Mode Grabbed key(%d) by wl_surface(%p)", i, surface);
-                    }
+                  krt->HardKeys[i].or_excl_ptr = eina_list_remove_list(krt->HardKeys[i].or_excl_ptr, l);
+                  E_FREE(key_node_data);
+                  KLDBG("Remove a Overridable_Exclusive Mode Grabbed key(%d) by wl_surface(%p)", i, surface);
                }
              else if ((wc == key_node_data->wc))
                {
@@ -312,14 +304,11 @@ e_keyrouter_remove_client_from_list(struct wl_resource *surface, struct wl_clien
           {
              if (!key_node_data) continue;
 
-             if (surface)
+             if (surface && (surface == key_node_data->surface))
                {
-                  if (surface == key_node_data->surface)
-                    {
-                       krt->HardKeys[i].top_ptr = eina_list_remove_list(krt->HardKeys[i].top_ptr, l);
-                       E_FREE(key_node_data);
-                       KLDBG("Remove a Topmost Mode Grabbed key(%d) by wl_surface(%p)", i, surface);
-                    }
+                  krt->HardKeys[i].top_ptr = eina_list_remove_list(krt->HardKeys[i].top_ptr, l);
+                  E_FREE(key_node_data);
+                  KLDBG("Remove a Topmost Mode Grabbed key(%d) by wl_surface(%p)", i, surface);
                }
              else if ((wc == key_node_data->wc))
                {
@@ -332,14 +321,11 @@ e_keyrouter_remove_client_from_list(struct wl_resource *surface, struct wl_clien
           {
              if (!key_node_data) continue;
 
-             if (surface)
+             if (surface && (surface == key_node_data->surface))
                {
-                  if (surface == key_node_data->surface)
-                    {
-                       krt->HardKeys[i].shared_ptr = eina_list_remove_list(krt->HardKeys[i].shared_ptr, l);
-                       E_FREE(key_node_data);
-                       KLDBG("Remove a Shared Mode Grabbed key(%d) by wl_surface(%p)", i, surface);
-                    }
+                  krt->HardKeys[i].shared_ptr = eina_list_remove_list(krt->HardKeys[i].shared_ptr, l);
+                  E_FREE(key_node_data);
+                  KLDBG("Remove a Shared Mode Grabbed key(%d) by wl_surface(%p)", i, surface);
                }
              else if ((wc == key_node_data->wc))
                {
@@ -352,14 +338,11 @@ e_keyrouter_remove_client_from_list(struct wl_resource *surface, struct wl_clien
           {
              if (!key_node_data) continue;
 
-             if (surface)
+             if (surface && (surface == key_node_data->surface))
                {
-                  if (surface == key_node_data->surface)
-                    {
-                       key_node_data->status = E_KRT_CSTAT_DEAD;
-                       KLDBG("Remove a Pressed  key(%d) by wl_surface(%p)", i, surface);
-                       key_node_data->wc = wl_resource_get_client(surface);
-                    }
+                  key_node_data->status = E_KRT_CSTAT_DEAD;
+                  KLDBG("Remove a Pressed  key(%d) by wl_surface(%p)", i, surface);
+                  key_node_data->wc = wl_resource_get_client(surface);
                }
              else if ((wc == key_node_data->wc))
                {
@@ -370,13 +353,10 @@ e_keyrouter_remove_client_from_list(struct wl_resource *surface, struct wl_clien
         EINA_LIST_FOREACH_SAFE(krt->HardKeys[i].pic_off_ptr, l, l_next, key_node_data)
           {
              if (!key_node_data) continue;
-             if (surface)
+             if (surface && (surface == key_node_data->surface))
                {
-                  if (surface == key_node_data->surface)
-                    {
-                       krt->HardKeys[i].pic_off_ptr = eina_list_remove_list(krt->HardKeys[i].pic_off_ptr, l);
-                       E_FREE(key_node_data);
-                    }
+                  krt->HardKeys[i].pic_off_ptr = eina_list_remove_list(krt->HardKeys[i].pic_off_ptr, l);
+                  E_FREE(key_node_data);
                }
              else if ( wc == key_node_data->wc)
                {