projects
/
platform
/
core
/
system
/
dumpsys.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
95ac664
)
Do not leak fifo_path
79/224579/1
accepted/tizen/unified/20200212.125745
submit/tizen/20200211.161552
submit/tizen_5.5/20200211.155751
submit/tizen_5.5/20200211.161648
submit/tizen_6.0/20200211.155831
author
Karol Lewandowski
<k.lewandowsk@samsung.com>
Tue, 11 Feb 2020 15:26:08 +0000
(16:26 +0100)
committer
Karol Lewandowski
<k.lewandowsk@samsung.com>
Tue, 11 Feb 2020 15:35:25 +0000
(16:35 +0100)
Change-Id: Ib8ed78d09c3ab0438f6786d91c86c8ae6d1f1f2f
src/dumpsys/dumpsys.c
patch
|
blob
|
history
diff --git
a/src/dumpsys/dumpsys.c
b/src/dumpsys/dumpsys.c
index
7d4a746
..
93d1cd1
100644
(file)
--- a/
src/dumpsys/dumpsys.c
+++ b/
src/dumpsys/dumpsys.c
@@
-87,12
+87,12
@@
static bool make_fifo(int *write_fd, int *read_fd)
uid_t ruid, euid, suid;
if (getresuid(&ruid, &euid, &suid) == -1) {
printf("getresuid error: %m\n");
-
return fals
e;
+
goto end_fre
e;
}
if (seteuid(suid) == -1) {
printf("setuid error: %m\n");
-
return fals
e;
+
goto end_fre
e;
}
if (mktemp(fifo_path) == NULL) {
@@
-142,11
+142,13
@@
static bool make_fifo(int *write_fd, int *read_fd)
result = true;
end:
- free(fifo_path);
if (seteuid(euid) == -1) {
printf("setuid error: %m\n");
result = false;
}
+end_free:
+ free(fifo_path);
+
return result;
}