Remove const from dbus::Connection::methodcall() 78/129878/3
authorKrzysztof Jackiewicz <k.jackiewicz@samsung.com>
Thu, 18 May 2017 08:20:08 +0000 (10:20 +0200)
committerSungbae Yoo <sungbae.yoo@samsung.com>
Tue, 23 May 2017 07:12:15 +0000 (07:12 +0000)
const Variant in return value disables the use of Variant's move constructor
so the only way to get it is by const Variant& which is not always preferred
option.

Change-Id: If6ac46e486444f69c946920ee6fa31fed100d134

include/klay/dbus/connection.h
src/dbus/connection.cpp

index 8a4020ada4013929413eae0a964d9d0ed739dfbd..11cf298ec3907f5bdd73df8f5cb52fec717d4e82 100644 (file)
@@ -66,14 +66,14 @@ public:
 
        void unsubscribeSignal(SubscriptionId id);
 
-       const Variant methodcall(const std::string& busName,
-                                                        const std::string& object,
-                                                        const std::string& interface,
-                                                        const std::string& method,
-                                                        int timeout,
-                                                        const std::string& replyType,
-                                                        const std::string& paramType,
-                                                        ...);
+       Variant methodcall(const std::string& busName,
+                                          const std::string& object,
+                                          const std::string& interface,
+                                          const std::string& method,
+                                          int timeout,
+                                          const std::string& replyType,
+                                          const std::string& paramType,
+                                          ...);
 
        void emitSignal(const std::string& busName,
                                        const std::string& object,
index dc39e1abe9086f2a67c6871867fbe0382ab5b7a8..5fee557e03aac8f2dbc5d5663d80b13c9decc3ee 100644 (file)
@@ -98,14 +98,14 @@ void Connection::unsubscribeSignal(Connection::SubscriptionId id)
        g_dbus_connection_signal_unsubscribe(connection, id);
 }
 
-const Variant Connection::methodcall(const std::string& busName,
-                                                                        const std::string& object,
-                                                                        const std::string& interface,
-                                                                        const std::string& method,
-                                                                        int timeout,
-                                                                        const std::string& replyType,
-                                                                        const std::string& paramType,
-                                                                        ...)
+Variant Connection::methodcall(const std::string& busName,
+                                                          const std::string& object,
+                                                          const std::string& interface,
+                                                          const std::string& method,
+                                                          int timeout,
+                                                          const std::string& replyType,
+                                                          const std::string& paramType,
+                                                          ...)
 {
        Variant result;
        Error error;