fix resource leak in error case 75/155775/2 accepted/tizen/unified/20171018.062604 submit/tizen/20171017.080630
authorSeokHoon Lee <andy.shlee@samsung.com>
Mon, 16 Oct 2017 06:36:08 +0000 (15:36 +0900)
committerSeokHoon Lee <andy.shlee@samsung.com>
Mon, 16 Oct 2017 06:39:53 +0000 (15:39 +0900)
- In error get mount, it will occur to leak resource of server.

Signed-off-by: SeokHoon Lee <andy.shlee@samsung.com>
Change-Id: Ib1976595220df35e57595d7208c0f21f56a6bedf

miracast_server/miracast_server_impl.c
packaging/capi-media-screen-mirroring.spec

index 797496c71fa236f63c5e1df83540f7ee953ebb1f..9c9db7136215af54301fd4b5ef562b4be2d67028 100644 (file)
@@ -210,6 +210,7 @@ void __miracast_server_quit_program(MiracastServer *server)
        void *pool = NULL;
        int i;
        int ret = 0;
+       int serv_ref_cnt = 0;
 
        if (server->server == NULL) {
                scmirroring_error("server is already NULL");
@@ -226,7 +227,7 @@ void __miracast_server_quit_program(MiracastServer *server)
                g_object_unref(pool);
        }
 
-       int serv_ref_cnt = GST_OBJECT_REFCOUNT_VALUE(server->server);
+       serv_ref_cnt = GST_OBJECT_REFCOUNT_VALUE(server->server);
        scmirroring_debug("serv ref cnt:%d", serv_ref_cnt);
 
        for (i = 0; i < serv_ref_cnt; i++)
@@ -627,6 +628,7 @@ int __miracast_server_start(MiracastServer *server_obj)
        mounts = gst_rtsp_server_get_mount_points(GST_RTSP_SERVER(server));
        if (NULL == mounts) {
                scmirroring_error("Failed to get mount point...");
+               g_object_unref(server);
                return SCMIRRORING_ERROR_INVALID_OPERATION;
        }
 
index 8d7cfa00d02d991be3acfa36d6dbfb6db2880ef2..87ff9e066a795c55ec2263e0159f0281c62503eb 100644 (file)
@@ -1,6 +1,6 @@
 Name:       capi-media-screen-mirroring
 Summary:    A screen mirroring library in Tizen C API
-Version:    0.1.87
+Version:    0.1.88
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0