Fix minor coverity issue

Since there was several minor defect catch in /usr/include,
It cannot be resolved forever.

To remove this error message, just fix it so we can remove defect.

Change-Id: I4aa10540c947bcf41cd5942d60069ea103e53740
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>

diff --git a/dali/devel-api/adaptor-framework/accessibility.h b/dali/devel-api/adaptor-framework/accessibility.h
index 7a8cb07..e4ff562 100644 (file)
--- a/dali/devel-api/adaptor-framework/accessibility.h
+++ b/dali/devel-api/adaptor-framework/accessibility.h
@@ -688,7 +688,7 @@ struct DALI_ADAPTOR_API Range
   Range(size_t start, size_t end, std::string content)\r
   : startOffset(start),\r
     endOffset(end),\r
-    content(content)\r
+    content(std::move(content))\r
   {\r
   }\r
 };\r

diff --git a/dali/integration-api/adaptor-framework/scene-holder.cpp b/dali/integration-api/adaptor-framework/scene-holder.cpp
index fb05c5d..2cf8584 100644 (file)
--- a/dali/integration-api/adaptor-framework/scene-holder.cpp
+++ b/dali/integration-api/adaptor-framework/scene-holder.cpp
@@ -41,22 +41,19 @@ SceneHolder::~SceneHolder()
 {
 }
 
-SceneHolder::SceneHolder(const SceneHolder& handle)
-: BaseHandle(handle)
-{
-}
+SceneHolder::SceneHolder(const SceneHolder& copy) = default;
+
+SceneHolder& SceneHolder::operator=(const SceneHolder& rhs) = default;
+
+SceneHolder::SceneHolder(SceneHolder&& rhs) noexcept = default;
+
+SceneHolder& SceneHolder::operator=(SceneHolder&& rhs) noexcept = default;
 
 SceneHolder::SceneHolder(Internal::Adaptor::SceneHolder* internal)
 : BaseHandle(internal)
 {
 }
 
-SceneHolder& SceneHolder::operator=(const SceneHolder& rhs)
-{
-  BaseHandle::operator=(rhs);
-  return *this;
-}
-
 void SceneHolder::Add(Actor actor)
 {
   GetImplementation(*this).Add(actor);

diff --git a/dali/integration-api/adaptor-framework/scene-holder.h b/dali/integration-api/adaptor-framework/scene-holder.h
index 61a8506..fd4f4f6 100644 (file)
--- a/dali/integration-api/adaptor-framework/scene-holder.h
+++ b/dali/integration-api/adaptor-framework/scene-holder.h
@@ -91,6 +91,21 @@ public:
   SceneHolder& operator=(const SceneHolder& rhs);
 
   /**
+   * @brief This move constructor is required for (smart) pointer semantics.
+   *
+   * @param [in] handle A reference to the moved handle
+   */
+  SceneHolder(SceneHolder&& handle) noexcept;
+
+  /**
+   * @brief This move assignment operator is required for (smart) pointer semantics.
+   *
+   * @param [in] rhs  A reference to the moved handle
+   * @return A reference to this
+   */
+  SceneHolder& operator=(SceneHolder&& rhs) noexcept;
+
+  /**
    * @brief Adds a child Actor to the SceneHolder.
    *
    * The child will be referenced.